950573 - Built-in Keyboard app could not input keys after it resumed from OOM

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

After switching keyboard OOP on, we would encounter an issue that the built-in keyboard could input keys even when the UI is correctly shown.

STR
===
1. Enabled keyboard OOP by setting 'keyboard.3rd-party-app.enabled': true in build/settings.js.
2. Try to launch many apps to make keyboard app killed due to OOM.
   (Or just kill the process)
3. Click on an input to launch the keyboard app again.
4. Type on the keyboard UI.

Expected result: everything works as normal.
Actual result: The UI and feedback (sound/vibration) works, but the keys pressed were not sent to the input field)

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

[Root Cause]
When the keyboard app is resumed after it was killed (due to OOM), most of the time, it goes to the route to invoke showKeyboard() in initKeyboard().
In this code path, we have to wait for the input method engine to load and then do showKeyboard(), or the latin input method won't get the correct state  - because its activate() was not invoked during showKeyboard().

[Solution]
Correct the init flow so that showKeyboard() would be invoked after setKeyboardName(), which will ensure input method engine is loaded.

--

Tim, could you help review this patch?

Comment 2

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8347942 [details] [diff] [review]
Patch V1

feedback+

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8347942 [details] [diff] [review]
Patch V1

Ouch.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/5376e75091d1347b8df6abb493d91ed8d7dce185

--
Tim, Gary,

Thanks for the review.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

See bug 991803 for the a easy STR to reproduce this issue on tarako.
That one has been nominated as v1.3T?, so carry forward here.

Since we backport the keyboard killing and resuming feature to v1.3t (see Bug 957880), we would need the fix here to correctly resume the keyboard app.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Joe,

ni to you for this issue, in case this won't be seen in triage since it has been resolved fixed months ago.
Please help read comment 6.
Thanks.

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ given the device can OOM due to limited memory, let's fix this in 1.3T

Comment 9

[ying.xu]

v1.3t
https://github.com/mozilla-b2g/gaia/commit/b58d0b4a44d20d478649b81e9d5ab9b26a59f511

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Verified the fix on Tarako 1.3T.  Keyboard worked correctly after crashing it using the steps in bug 991803

1.3T Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140501014002
Gaia: d26a776beae0070b0032248a2ce482bbe6321a6d
Gecko: e90f4b655511
Version: 28.1
Firmware Version: sp6821a-Gonk-4.0-4-29