950622 - [Download Manager] The % of the download is not displayed in a notification for files with long names

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[rafael.marquez]

Attachment: nombre largo.jpg

*Procedure
1. Download a  file
2. Open notification bar during the download process

*Expected result
the % of the download and file name are displayed during the download

*Actual Result
The % of the download is not displayed in a notification for files with long names

Comment 1

[Cristian Rodriguez (:crdlc)]

Hi Francis,

   I was thinking about this issue and I would like to suggest an idea. I think that is better to use this alternative:

<n><%> <separator> <filename.ext>

instead of this one

<filename.ext> <separator> <n><%>

   I guess that it looks better IMHO

10% - my_file_name_very_lon...

   than

my_file_name_very_lon... - 10%

What do you think about this new alternative?

This second alternative is also for free regarding to implementation. The first approach is more complicated from my side. This is not a strong blocker so up to you

Thanks a lot Francis

Comment 2

[Cristian Rodriguez (:crdlc)]

I forgot to add the needinfo :(

Comment 3

[Cristian Rodriguez (:crdlc)]

Hi, any update? Thanks a lot

Comment 4

[rafael.marquez]

any UX update?

Comment 5

[Francis Djabri [:djabber]]

Hi Cristian, sorry for the late reply. I agree with your approach - I will make an update to the Spec to address this. Keeping myself as need info for now.

Comment 7

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8364385 [details]
Patch v1

Clever ;)

Comment 9

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/bb326d71034aeb9acabb0319886896511e179e41

Comment 10

[rafael.marquez]

Verified in master

Comment 11

[Francis Djabri [:djabber]]

Spec updated in version 0.15 on Box at: https://mozilla.box.com/s/gw84uv5ykmufiec4acl3

Comment 12

[Francis Djabri [:djabber]]

(In reply to Francis Djabri [:djabber] from comment #11)
> Spec updated in version 0.15 on Box at:
> https://mozilla.box.com/s/gw84uv5ykmufiec4acl3

Sorry, actually in version 0.16 - https://mozilla.box.com/s/5q5rehaw2z2kgyeag43n

Version 0.16 updates the document to account for this bug but has no other changes from version 0.15.