[Contacts] Review public interface for classes and move code to their specific component

RESOLVED INVALID

Status

Firefox OS
Gaia::Contacts
RESOLVED INVALID
5 years ago
4 years ago

People

(Reporter: arcturus, Assigned: michalbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

With Hayda coming we need to review what is exposed in each javascript class in order to load just the necessary javascript per document.

We will need to review the public interfaces of the main contact classes and move the code to the specific views that is needed, otherwise separate it and make it accessible from different documents in smaller pieces.

Examples of that are:

- contacts.js has a method callOrPick which is used just in the detail view (detail.js)
Blocks: 946750
I've been syncing with Michal, and he will be taking this task, I'll be happy to review.

Cheers,
F.
(Assignee)

Updated

5 years ago
Assignee: nobody → mbudzynski

Comment 2

5 years ago
What release are we hoping to get this into?  1.4?
Hopefully, so far it's not a committed feature.

Comment 4

5 years ago
this is a very generic bug. I would suggest to be more concrete on what's planned and to split in small pieces to avoid regressions and to make it easier to review when ready
Yes, this bug should be first an analysis of what should go in each class.
The contacts.js has been already refactor, it doesnt containg the method |callOrPick| anymore.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.