950665 - [Contacts] Review public interface for classes and move code to their specific component

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

With Hayda coming we need to review what is exposed in each javascript class in order to load just the necessary javascript per document.

We will need to review the public interfaces of the main contact classes and move the code to the specific views that is needed, otherwise separate it and make it accessible from different documents in smaller pieces.

Examples of that are:

- contacts.js has a method callOrPick which is used just in the detail view (detail.js)

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

I've been syncing with Michal, and he will be taking this task, I'll be happy to review.

Cheers,
F.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

What release are we hoping to get this into?  1.4?

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hopefully, so far it's not a committed feature.

Comment 4

[Jose Manuel Cantera]

this is a very generic bug. I would suggest to be more concrete on what's planned and to split in small pieces to avoid regressions and to make it easier to review when ready

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Yes, this bug should be first an analysis of what should go in each class.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

The contacts.js has been already refactor, it doesnt containg the method |callOrPick| anymore.