946750 - [Haida][Contacts] Contacts app should use Haida pattern to change views

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Michał Budzyński (:michalbe)]

Contacts app should use separate sheets for every view, and use window.open instead of build-in navigation module.

Comment 1

[Michał Budzyński (:michalbe)]

I've merged sheets support provided by bug #961800 on bubble-tea branch yesterday and found some regressions & parts of the app that are not working (mostly because I couldn't test them before because of the one-popup-per-app limitation). I'm working now on fixing all of them [1], I should finally have patch ready to r? early next week. In the meantime, parts of my WIP patch can be checked in my contacts-haida branch [2]. 

Because of the change in architecture, most of the test are failing so far. I'll finish fixing them just after I'll fix all the regressions.

[1] Etherpad with things that don't work as expected https://etherpad.mozilla.org/contacts-haida-regressions
[2] https://github.com/michalbe/gaia/tree/contacts-haida

Comment 2

[Michał Budzyński (:michalbe)]

According to things decided on Contacts workweek last week, solving this bug will be separated into two steps described in the Etherpad document [1]. First part (separating views, but keeping current navigation pattern) is Bug #952490, second step is Bug #952563. 

[1] https://etherpad.mozilla.org/contacts-haida

Comment 3

[Michał Budzyński (:michalbe)]

Work in progress - last week I've separated HTML of 'add new contact' form and implement first state of the iframe based navigation [1]. Instead of using Haida pattern supported in system I created separate iframe for each view and load view's html document inside (just for the 'form' view for now). The iframe after that behaves like 'section' elements before, there is no difference for end user.

[1] https://github.com/michalbe/gaia/commit/fe342416637414292003e21f00f841794cad0ad9

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Nice, is the whole work in this branch?

https://github.com/michalbe/gaia/compare/module-separation-contacts-haida

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Some comments, with the current WIP, just to take into account before any review:

- We won't need all css and js now in form.js
- Remove dead code (I know you'll in a cleaning step ;P)

And that's all I've seen \o/

Looking forward for the next iterations!

Thanks a lot Michal!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Btw, just saw the visual refresh for contacts starting to land:

https://bugzilla.mozilla.org/show_bug.cgi?id=966224

The sooner we rebase the better.

Thanks!

Comment 7

[Michał Budzyński (:michalbe)]

About your comment - in this branch I focus on navigation, I'll merge with the rest later this week.

Comment 8

[Michał Budzyński (:michalbe)]

'Rest' of the contact app (all the views etc.).

Comment 9

[Michał Budzyński (:michalbe)]

WIP update: I've pushed next part of the navigation system in michalbe/gaia:module-separation-contacts-haida. What it basically do is creating a new navigaitonStack object that is used in all the child views (not the main view) inside the iframes. Every time any of it's methods is called it sends postMsg to the parent window with request to the navigation action (haida-navigation-shim-receiver.js in main view). Rest of the logic is unchanged, so it behaves as before.

I'm now merging new changes to my branch, finish separating views and complete the navigation-shim with needed actions.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Thanks!!

Looking forward for more changes, did you had any problem with iframes created during different imports?

Comment 11

[Michał Budzyński (:michalbe)]

I didn't get to this part so far, I have some mess in settings and trying to resolve it now.

Comment 12

[Michał Budzyński (:michalbe)]

Attachment: [WIP] patch

Finally, first WIP patch prepared. Some tests are still failing, but since it's a huge architecture change, I would love :arcturus to start reviewing it while I'll fix them.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8436912 [details] [review]
[WIP] patch

Also asking for Jose's review here.

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

BTW, just realised, should this patch be attached to a specific bug for the form view?

As I'm seeing this is the meta for whole haida effort, and looks to me as it should be in a separate bug.

Comment 15

[Michał Budzyński (:michalbe)]

Ok, filing a bug now.

Comment 16

[BMO Automation]

Firefox OS is not being worked on