950904 - Add telemetry probes for screen dimensions and/or aspect ratio

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[Sam Foster [:sfoster] (he/him)]

To inform v2 UI plans and improvements, it would be useful to understand what screen sizes people typically use Firefox for Metro in. Although we support rotation and landscape/portrait mode, given that split view exists the actual window dimensions and ratio are more useful. 

The aspect ratio is easily calculated given the dimensions, but if its turns out reporting will be easier with a separate value, we should do that too.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Looking into this

Comment 2

[Sam Foster [:sfoster] (he/him)]

Similar to bug 683071, though we'll need metro-specific data.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Add UITelemetry probe to capture window width & height

Using the UITelemetry module to report window width and height (via ContentAreaObserver), plus test to reassure myself it actually works (it does). 

This approach means we'll get whatever width/height values happen to be in play at the time the TelemetryPing comes around. That's a bit arbitrary, but seems as good as any other strategy? We could also listen for resize and update a value but you would get the same end result. 

We haven't discussed a plan for how we'll organize and consume this UI telemetry data. With this patch I'm proposing that this is simple measures data, in the UITelemetry.metro-ui "namespace". (vs. individual WINDOW_WIDTH/WINDOW_HEIGHT histograms)

Comment 4

[Jim Mathies [:jimm]]

(In reply to Sam Foster [:sfoster] from comment #3)
> Created attachment 8368964 [details] [diff] [review]
> Add UITelemetry probe to capture window width & height
> 
> Using the UITelemetry module to report window width and height (via
> ContentAreaObserver), plus test to reassure myself it actually works (it
> does). 
> 
> This approach means we'll get whatever width/height values happen to be in
> play at the time the TelemetryPing comes around. That's a bit arbitrary, but
> seems as good as any other strategy? We could also listen for resize and
> update a value but you would get the same end result. 

I like the randomness of it. 

> 
> We haven't discussed a plan for how we'll organize and consume this UI
> telemetry data. With this patch I'm proposing that this is simple measures
> data, in the UITelemetry.metro-ui "namespace". (vs. individual
> WINDOW_WIDTH/WINDOW_HEIGHT histograms)

Should we add orientation to this? Maybe that's in another bug.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/b6cc3c35d419

jimm: My understand is that reporting is done via map/reduce, so we should be able to pull orientation out of the height/width data we log here. It doesn't tell is if the tablet has been rotated vs. portrait-mode via split screen, but from a UI point of view, we mostly care about landscape (width > height), vs portrait (height > width).

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6cc3c35d419

Comment 7

[Carsten Book [:Tomcat]]

correcting target milestone, sorry for the bugmail spam

Comment 8

[Manuela Muntean [Away]]

Could anyone please give guidance in order for the QA to verify this?

Comment 9

[Sam Foster [:sfoster] (he/him)]

In about:telemetry, under the Simple Measures you should see something like "metro-ui": {"window-width":1600,"window-height":900} under the UITelemetry property.

Comment 10

[Kamil Jozwiak [:kjozwiak]]

Went through the following verification process with the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-23-03-02-04-mozilla-central/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-23-00-40-01-mozilla-aurora/

Following Sam's instructions from comment #9, I installed and started fxmetro in full view and other variations of snapped view. Made sure that the correct telemetry data was correctly being displayed.

Telemetry data on the X1 Carbon: (appeared correctly on both Nightly/Aurora)
- "metro-ui": {"window-width":1600,"window-height":900}
- "metro-ui": {"window-width":1078,"window-height":900}
- "metro-ui": {"window-width":963,"window-height":900}
- "metro-ui": {"window-width":789,"window-height":900}

Telemetry data on the Surface Pro 2: (appeared correctly on both Nightly/Aurora)
- "metro-ui": {"window-width":1376,"window-height":774}
- "metro-ui": {"window-width":853,"window-height":774}
- "metro-ui": {"window-width":677,"window-height":774}
- "metro-ui": {"window-width":502,"window-height":774}