951118 - TypeError: this.whenKeysReadyPromise is null after account is verified

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

Gecko  I  *************************
Gecko  I  A coding exception was thrown in a Promise resolution callback.
Gecko  I  Full message: TypeError: this.whenKeysReadyPromise is null
Gecko  I  See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Gecko  I  Full stack: InternalMethods.prototype.getKeys/<@resource://gre/modules/FxAccounts.jsm:154
Gecko  I  Handler.prototype.process@resource://gre/modules/Promise.jsm:767
Gecko  I  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:531
Gecko  I  *************************

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

I see this, too, in the execution of the test_getKeys_no_token() test in test_accounts.js.  I'll take a look.

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: 951118-null-promise.patch

I think this fixes the reported bug, as well as another error in the tests.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8348931 [details] [diff] [review]
951118-null-promise.patch

Review of attachment 8348931 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Jed!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/f3d509e75433

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f3d509e75433