Closed Bug 951118 Opened 10 years ago Closed 10 years ago

TypeError: this.whenKeysReadyPromise is null after account is verified

Categories

(Firefox OS Graveyard :: FxA, defect)

Product:
Firefox OS Graveyard
Component:
FxA
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ferjm, Assigned: jedp)

References

Details

Attachments

(1 file)

951118-null-promise.patch
2.98 KB, patch
ferjm
: review+
Details | Diff | Splinter Review 
Gecko  I  *************************
Gecko  I  A coding exception was thrown in a Promise resolution callback.
Gecko  I  Full message: TypeError: this.whenKeysReadyPromise is null
Gecko  I  See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Gecko  I  Full stack: InternalMethods.prototype.getKeys/<@resource://gre/modules/FxAccounts.jsm:154
Gecko  I  Handler.prototype.process@resource://gre/modules/Promise.jsm:767
Gecko  I  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:531
Gecko  I  *************************
I see this, too, in the execution of the test_getKeys_no_token() test in test_accounts.js.  I'll take a look.
Assignee: nobody → jparsons
I think this fixes the reported bug, as well as another error in the tests.
Attachment #8348931 - Flags: review?(ferjmoreno)
Comment on attachment 8348931 [details] [diff] [review]
951118-null-promise.patch

Review of attachment 8348931 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Jed!
Attachment #8348931 - Flags: review?(ferjmoreno) → review+
https://hg.mozilla.org/integration/fx-team/rev/f3d509e75433
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f3d509e75433
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.