Closed
Bug 951298
Opened 10 years ago
Closed 10 years ago
placing 5 icons in the dock and then going in and out of edit mode on the homescreen will chop the 5th icon
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed)
Tracking | Status | |
---|---|---|
b2g-v1.3 | --- | fixed |
People
(Reporter: nhirata, Assigned: vingtetun)
References
Details
(Whiteboard: [apz_testrun])
Attachments
(2 files, 4 obsolete files)
328.96 KB,
image/png
|
Details | |
710 bytes,
patch
|
crdlc
:
review+
|
Details | Diff | Splinter Review |
Steps to Reproduce: 1. use the APZ build and turn APZ and reboot 2. place an icon in the dock 3. long tap on an icon to get into edit mode on the homescreen 4. tap the home button to exit the homescreen Expected Results: icons are correctly displayed on the homescreen including the dock Actual Results: the 5th icon is chopped Additional Notes: Environmental Variables: Build : Gaia 504cf9a988cd84760b4040706ccc41e508a97fd2 Gecko 55b75ce2263e7d2a8cbfdabc7e5206d9caa89f98 BuildID 20131216140918 Version 28.0a2 ro.build.version.incremental=eng.archermind.20131114.105818 ro.build.date=Thu Nov 14 10:58:33 CST 2013 RIL Type : Mozilla RIL OS Version: 1.3 Device: Buri
Assignee | ||
Comment 1•10 years ago
|
||
Nice catch. The icon is chopped even if the user scroll the dock.
Blocks: gaia-apzc
Assignee | ||
Updated•10 years ago
|
blocking-b2g: --- → 1.3?
Assignee | ||
Comment 2•10 years ago
|
||
The homescreen app is doing something funny. The box is not scrollable before the items are added. Once a fifth icon is added, then the width of the icons inside is updated to be smaller.
Assignee | ||
Comment 3•10 years ago
|
||
There is definitively some Gecko weirdness inside. Here is a Gaia workaround.
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8349472 [details] [diff] [review] bug951298.gaiaworkaround.patch Christian, this is a workaround around a gecko bug with async pan zoom turned on. You won't see the bug unless you turn the pref on in Settings -> Informations -> More Informations -> Developer -> APZC for all processes The target for this patch is 1.3, that's why I want to workaround the gecko issue instead of fixing it directly. Then we can fix the Gecko issue in 1.4.
Attachment #8349472 -
Flags: review?(crdlc)
Comment 5•10 years ago
|
||
Comment on attachment 8349472 [details] [diff] [review] bug951298.gaiaworkaround.patch My apologies for the r- but the result is not correct. 1) Unexpected bottom margin http://i.imgur.com/y1uHz90.png 2) Wrong space among icons http://i.imgur.com/vanI68A.png
Attachment #8349472 -
Flags: review?(crdlc) → review-
Assignee | ||
Comment 6•10 years ago
|
||
Don't apologize for r-! :) I don't see the margin on my phone funily but I bet this is because of the background I have which is opaque at the bottom. I will fix that.
Comment 7•10 years ago
|
||
I tested it without APZ Vivien
Assignee | ||
Comment 8•10 years ago
|
||
I don't really see the margin issue between apps (i took 2 screenshoots and compare them). So let me now if you still see it.
Attachment #8349472 -
Attachment is obsolete: true
Attachment #8349960 -
Flags: review?(crdlc)
Comment 9•10 years ago
|
||
Comment on attachment 8349960 [details] [diff] [review] bug951298.v2.patch Follow our offline conversation, thanks
Attachment #8349960 -
Flags: review?(crdlc)
Assignee | ||
Comment 10•10 years ago
|
||
Christian, this is a much less invasive patch. Let me know if it works for you.
Attachment #8349960 -
Attachment is obsolete: true
Attachment #8349995 -
Flags: review?(crdlc)
Assignee | ||
Comment 11•10 years ago
|
||
The root core issue sounds like a fixed positioning clipping issue. But then If I simply change the code to absolute, there is some background issue where Gecko force the background to be black...
Assignee | ||
Comment 12•10 years ago
|
||
Oups I added some changes for an other bug in the previous patch.
Attachment #8349995 -
Attachment is obsolete: true
Attachment #8349995 -
Flags: review?(crdlc)
Attachment #8349996 -
Flags: review?(crdlc)
Comment 13•10 years ago
|
||
It works perfect in my device, I gonna check the code
Comment 14•10 years ago
|
||
Comment on attachment 8349996 [details] [diff] [review] bug951298.v3.patch It works fine in my device and the code looks good to me. The main pending issue is to review the media queries that will be affected by this change about height. Thanks
Attachment #8349996 -
Flags: review?(crdlc)
Assignee | ||
Comment 15•10 years ago
|
||
OK, I think I found the minimal change to make this working without having to change any dimensions.
Attachment #8349996 -
Attachment is obsolete: true
Attachment #8350021 -
Flags: review?(crdlc)
Comment 16•10 years ago
|
||
Comment on attachment 8350021 [details] [diff] [review] bug951298.v4.patch Perfect! Good job! Thanks a lot
Attachment #8350021 -
Flags: review?(crdlc) → review+
Updated•10 years ago
|
Assignee: nobody → 21
Status: NEW → ASSIGNED
Assignee | ||
Comment 17•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/10770ace5dac9cef7b19c8748a4d3c447b2690f2
blocking-b2g: 1.3? → 1.3+
Component: Gaia → Gaia::Homescreen
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Assignee | ||
Comment 18•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/5d31cfb04081605a5c4cddd97022ed3210e9bdd0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-b2g-v1.3:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•