951298 - placing 5 icons in the dock and then going in and out of edit mode on the homescreen will chop the 5th icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2013-12-17-10-53-32.png

Steps to Reproduce:

1. use the APZ build and turn APZ and reboot 
2. place an icon in the dock
3. long tap on an icon to get into edit mode on the homescreen
4. tap the home button to exit the homescreen 

Expected Results:  icons are correctly displayed on the homescreen including the dock

Actual Results: the 5th icon is chopped

Additional Notes:

Environmental Variables:
Build : 
Gaia      504cf9a988cd84760b4040706ccc41e508a97fd2
Gecko     55b75ce2263e7d2a8cbfdabc7e5206d9caa89f98
BuildID   20131216140918
Version   28.0a2
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013
RIL Type : Mozilla RIL
OS Version: 1.3
Device: Buri

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Nice catch. The icon is chopped even if the user scroll the dock.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The homescreen app is doing something funny. The box is not scrollable before the items are added. Once a fifth icon is added, then the width of the icons inside is updated to be smaller.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug951298.gaiaworkaround.patch

There is definitively some Gecko weirdness inside. Here is a Gaia workaround.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8349472 [details] [diff] [review]
bug951298.gaiaworkaround.patch

Christian, this is a workaround around a gecko bug with async pan zoom turned on. You won't see the bug unless you turn the pref on in Settings -> Informations -> More Informations -> Developer -> APZC for all processes

The target for this patch is 1.3, that's why I want to workaround the gecko issue instead of fixing it directly. Then we can fix the Gecko issue in 1.4.

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8349472 [details] [diff] [review]
bug951298.gaiaworkaround.patch

My apologies for the r- but the result is not correct.

1) Unexpected bottom margin

http://i.imgur.com/y1uHz90.png

2) Wrong space among icons

http://i.imgur.com/vanI68A.png

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Don't apologize for r-! :) I don't see the margin on my phone funily but I bet this is because of the background I have which is opaque at the bottom. I will fix that.

Comment 7

[Cristian Rodriguez (:crdlc)]

I tested it without APZ Vivien

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug951298.v2.patch

I don't really see the margin issue between apps (i took 2 screenshoots and compare them). So let me now if you still see it.

Comment 9

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8349960 [details] [diff] [review]
bug951298.v2.patch

Follow our offline conversation, thanks

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug951298.v3.patch

Christian, this is a much less invasive patch. Let me know if it works for you.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The root core issue sounds like a fixed positioning clipping issue.

But then If I simply change the code to absolute, there is some background issue where Gecko force the background to be black...

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug951298.v3.patch

Oups I added some changes for an other bug in the previous patch.

Comment 13

[Cristian Rodriguez (:crdlc)]

It works perfect in my device, I gonna check the code

Comment 14

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8349996 [details] [diff] [review]
bug951298.v3.patch

It works fine in my device and the code looks good to me. The main pending issue is to review the media queries that will be affected by this change about height. Thanks

Comment 15

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug951298.v4.patch

OK, I think I found the minimal change to make this working without having to change any dimensions.

Comment 16

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8350021 [details] [diff] [review]
bug951298.v4.patch

Perfect! Good job! Thanks a lot

Comment 17

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/10770ace5dac9cef7b19c8748a4d3c447b2690f2

Comment 18

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/5d31cfb04081605a5c4cddd97022ed3210e9bdd0