multi-apzc, 814435, 898444, 907179, 907754, 909881, 909887, 915872, 916125, 916185, 929728, 933264, 938312, 940036, 940691, 941215, 941294, 942726, 942752, 942754, 942760, 942799, 942850, 942854, 942856, 942863, 942929, 943831, 943846, 943858, 943882, 944511, 944759, 944898, 946172, 946339, 946408, 946545, 946999, 947354, 947552, 948001, 948396, 949404, 950300, 950487, 950488, 950489, 950993, 951113, 951290, 951298, 951308, 951321, 951342, 951357, 951375, 951458, 957188, 957790, 957925, 958208, 958245, 958650, 959144, 959198, 959199, 960120, 960163, 961047, 962791, 964421, 964981, 964997, 966397, 966476, 966507, 969483, 972091, 975033, 980041, 980679, 982888, 987771, 996991
Currently subframe scrolling in Gaia apps happens using BrowserElementPanning.js and occurs synchronously. This bug tracks all the work needed to switch that over to AsyncPanZoomController's async panning.
Created attachment 796178 [details] [diff] [review] WIP - turn on APZC on everything in gaia For the record this is what I'm using as my current hack to "turn on APZC everywhere". It may not be correct but it's good enough to find out what bugs need fixing.
We should keep an eye on the FPS (e.g., bug 912134) as we convert the apps, as a sanity check that the performance is not regressing with these changes.
To turn this on by default, check 929728 which introduced the preference. Not ready for it yet.
Spoke with nhirata in person about this - he's going to drive the QA testing on this.
Is there any UX design required for this? Or is APZC mainly related to performance?
(In reply to Rob MacDonald [:robmac] from comment #6) > Is there any UX design required for this? Or is APZC mainly related to > performance? Afaict APZC in this bug is mostly related to performance. I believe that there are some UX questions that can be discussed into relevant bugs. For example about overscroll indicators in bug 775469. Or about the panning heuristic, or event about when to display scrollbars and when not, etc... IMHO the main consideration you should have here is that APZC will unify the scrolling behavior between Gaia Web Browser and Apps running in Firefox OS. The behavior will be derived from the current behavior of the browser app, so if there are things that UX does not like in it, feel free to open bugs to that blocks this one and let's discuss the details there.
Depends on: 942726
Depends on: 942752
Depends on: 942754
Depends on: 942760
Depends on: 942799
Depends on: 942850
Depends on: 942854
Depends on: 942856
Depends on: 942863
Depends on: 941215
Depends on: 942929
Depends on: 943831
Depends on: 943841
Depends on: 941294
Depends on: 943858
Duplicate of this bug: 942760
Depends on: 943882
Depends on: 814435
Depends on: 943846
Depends on: 944759
Depends on: 944898
(In reply to Rob MacDonald [:robmac] from comment #6) > Is there any UX design required for this? Or is APZC mainly related to > performance? What Vivien said.
Is this gonna be in 1.3 after all?
(In reply to Jan Jongboom [:janjongboom] from comment #10) > Is this gonna be in 1.3 after all? The target is 1.3.
Depends on: 938312
Depends on: 946172
Depends on: 946339
Depends on: 946999
Depends on: 947337
Depends on: 947552
Depends on: 948001
Depends on: 948396
(From FxOS Perf triage) I thought we didn't 1.3+ meta bug?
Depends on: 949404
(In reply to Hubert Figuiere [:hub] from comment #12) > (From FxOS Perf triage) I thought we didn't 1.3+ meta bug? It doesn't hurt, and it makes it easier to make sure dependent bugs are triaged. Sometimes we forget to put a 1.3? or 1.3+ on the blockers.
No longer depends on: 945789
Depends on: 940889
No longer depends on: 940889
No longer depends on: 943841
Depends on: 950300
Depends on: 950301
Depends on: 950487
Depends on: 950488
Depends on: 950489
The patch doesn't apply to the current 1.3 build. Need to talk to kats to figure out where to apply the patch.
Comment on attachment 796178 [details] [diff] [review] WIP - turn on APZC on everything in gaia The patch is obsolete now. There is an option in the gaia settings to enable APZ
Attachment #796178 - Attachment is obsolete: true
Depends on: 951113
Depends on: 951298
Depends on: 951284
No longer depends on: 951284
Vivien, What are the next steps here?
Flags: needinfo?(praghunath) → needinfo?(21)
Pull request pending merge at https://github.com/mozilla-b2g/gaia/pull/15122 to enable by default.
(In reply to Kartikaya Gupta (email:firstname.lastname@example.org) from comment #17) > Pull request pending merge at https://github.com/mozilla-b2g/gaia/pull/15122 > to enable by default. Are you looking for someone to review that patch?
There's not much to review. Milan asked me to make the change and fabrice said he would merge it once the travis run is green.
(In reply to Fabrice Desré [:fabrice] from comment #20) > https://github.com/mozilla-b2g/gaia/commit/ > 236e4f96cbfdaf2c90c12ebf61107dd274e7fd73 Should we mark this fixed with this landing then?
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [c= p= s= u=] → [c=handeye p= s=2014.01.17 u=1.3]
I'm unsure of the gaia branching model but I believe this will need to be merged to 1.3 as well.
status-b2g-v1.2: --- → wontfix
status-b2g-v1.3: --- → affected
This does not uplift cleanly: $ git diff * Unmerged path build/config/common-settings.json $ git status <snip> Unmerged paths: (use "git add/rm <file>..." as appropriate to mark resolution) deleted by us: build/config/common-settings.json
I made a rebased version on the latest mozillaorg/v1.3 code: https://github.com/staktrace/gaia/commit/969448b53a9148e58880f64c7a12425ddef99dda Please let me know if you require it in some other format.
Depends on: 951375
[v1.3 226aa05] Bug 909877 - Enable APZ for all of gaia. rs=milan
status-b2g-v1.3: affected → fixed
Depends on: 958036
Next step has already been done. Clearing.
No longer depends on: 958036
No longer depends on: 950301
Depends on: 959144
Depends on: 960120
Depends on: 959425
generic apz test created to cover a lot of things to check.
Flags: in-moztrap?(nhirata.bugzilla) → in-moztrap+
No longer depends on: 965004
Depends on: 968145
No longer depends on: 959414
No longer depends on: 972675
Depends on: 972091
No longer depends on: 977295
status-b2g-v1.3T: --- → fixed
status-b2g-v1.4: --- → fixed
You need to log in before you can comment on or make changes to this bug.