951364 - [Australis] button context menu should offer to "move", not "add"

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

The context menu for buttons on the toolbar offers "Add to Menu", and conversely the context menu for buttons in the menu panel offers "Add to Toolbar". It would be a little clearer if these were instead "Move to Menu" / "Move to Toolbar", since that's what's happening (the location of the button is changing, it's not additive).

The context menu for items in the customization palette should stay the same, I think. (Since the user is "adding" a button to their UI.)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8348979 [details] [diff] [review]
Patch v.1

Review of attachment 8348979 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/browser.dtd
@@ +335,5 @@
>  <!ENTITY customizeMenu.addToPanel.accesskey "M">
> +<!ENTITY customizeMenu.moveToToolbar.label "Move to Toolbar">
> +<!ENTITY customizeMenu.moveToToolbar.accesskey "M">
> +<!ENTITY customizeMenu.moveToPanel.label "Move to Menu">
> +<!ENTITY customizeMenu.moveToPanel.accesskey "M">

These shouldn't share the same accesskey since they are both visible at the same time when in the context menu of an item in the palette. Please switch the Toolbar context menu item to T (as long as it doesn't conflict in other scenarios).

Comment 2

[Justin Dolske [:Dolske]]

(In reply to Jared Wein [:jaws] (Away 20 Dec to 2 Jan) from comment #1)

> > +<!ENTITY customizeMenu.moveToToolbar.label "Move to Toolbar">
> > +<!ENTITY customizeMenu.moveToToolbar.accesskey "M">
> > +<!ENTITY customizeMenu.moveToPanel.label "Move to Menu">
> > +<!ENTITY customizeMenu.moveToPanel.accesskey "M">
> 
> These shouldn't share the same accesskey since they are both visible at the
> same time when in the context menu of an item in the palette. Please switch
> the Toolbar context menu item to T (as long as it doesn't conflict in other
> scenarios).

Nope. Only one of these will be visible at a time (depending on where the button is).

As noted in comment 0, items in the customization palette will still have the existing "Add to Menu" and "Add to Toolbar" items (which are both shown concurrently).

Comment 3

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/integration/fx-team/rev/8e25403f7096

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8e25403f7096

Comment 5

[Gabriela [:gaby2300]]

Verified fixed using Windows 7 64 bit and Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0