Closed
Bug 952742
Opened 11 years ago
Closed 11 years ago
[Australis] "Move to menu" label is using the wrong entity for accesskey
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
VERIFIED
FIXED
Firefox 29
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
|
1.35 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#249
247 <menuitem oncommand="gCustomizeMode.addToPanel(document.popupNode)"
248 accesskey="&customizeMenu.addToPanel.accesskey;"
249 label="&customizeMenu.moveToPanel.label;"
250 class="customize-context-moveToPanel"/>
Accesskey should set to "customizeMenu.moveToPanel.accesskey"
Reference changeset: https://hg.mozilla.org/mozilla-central/rev/8e25403f7096
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [Australis:P4]
|
|
Assignee | |
Comment 1•11 years ago
|
||
Unless I'm missing something obvious, this should be enough to fix it.
Assignee: nobody → francesco.lodolo
Attachment #8350897 -
Flags: review?(dolske)
|
|
Assignee | |
Updated•11 years ago
|
Summary: [Australis] "Move to menu" label is using the wrong accesskey → [Australis] "Move to menu" label is using the wrong entity for accesskey
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8350897 [details] [diff] [review]
Replace entity name in accesskey attribute
Review of attachment 8350897 [details] [diff] [review]:
-----------------------------------------------------------------
derp=me. Nice catch.
Attachment #8350897 -
Flags: review?(dolske) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
You need to log in
before you can comment on or make changes to this bug.
Description
•