95159 - autocomplete preferences ambiguous

Status: VERIFIED FIXED

(SeaMonkey :: Autocomplete, defect, P4)

Description

[Diego Biurrun]

This continues bug 84809 as duggested by Dean Tessman..

In the preferences the "Advanced" button should be disabled if "Enable Location
bar autocomplete" is not checked.

Comment 1

[Diego Biurrun]

Attachment: first try

Comment 2

[Diego Biurrun]

OK, to celebrate bugweek I hacked together my first mozilla patch. Code review
would be greatly appreciated. Bear in mind that I am completely new to this. It
is a trivial patch, but there are probably endless opportunities for error.

Comment 3

[Joe Hewitt (gone)]

Comment on attachment 56244 [details] [diff] [review]
first try

thanks for the patch, diego

sr=hewitt, however, could you please change the formatting of that if statement to be like this:

if (a)
  b;
else
  c;

Comment 4

[Diego Biurrun]

Attachment: formatting updated

Comment 5

[Diego Biurrun]

Your wish is my command, hewitt ;)

I changed the formatting of the if statement. Hope this is good enough now.

Comment 6

[Diego Biurrun]

Come on Hewitt, check it in, make me famous and the envy of all my friends ;-)
This should be safe enough for 0.9.6.

Comment 7

[Diego Biurrun]

Attachment: updated patch, there was some bitrot

The file I edited changed, here is the updated patch.

Comment 8

[Diego Biurrun]

Attachment: patch that patch can apply

Seems like I catched a glitch in patch maker here. This version of the patch
should be applyable with patch. Have fun.

Comment 9

[Samir Gehani]

Comment on attachment 57921 [details] [diff] [review]
patch that patch can apply

r=sgehani

Comment 10

[Joe Hewitt (gone)]

checked in

Comment 11

[Diego Biurrun]

VERIFIED on latest Linux and Windows nightly builds ---> VERIFIED