95160 - Gdk-CRITICAL errors reading news

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Michael Marxmeier]

Build ID 2001081008, Linux

Reading a newsgroup messages cause these messages to be displayed:

Gdk-CRITICAL **: file gdkpixmap.c: line 822 (gdk_pixmap_unref): assertion
`pixmap != NULL' failed.

Gdk-CRITICAL **: file gdkpixmap.c: line 63 (gdk_pixmap_new): assertion `(width
!= 0) && (height != 0)' failed.

Gdk-CRITICAL **: file gdkdraw.c: line 89 (gdk_draw_rectangle): assertion
`drawable != NULL' failed.

Comment 1

[Håkan Waara]

This is most likely a libpr0n problem.

Over to imagelib.

Comment 2

[Vladimir Bossicard]

Also appears when changing locale on the browser.

Comment 3

[Scott Davis]

Same assertions, same line numbers when reading E-mail with build ID 2001081410
on Solaris/SPARC.

Comment 4

[R.K.Aa.]

*** Bug 95597 has been marked as a duplicate of this bug. ***

Comment 5

[R.K.Aa.]

i see these in mailnews, and in sidebar and prefs, for instance, when clicking a
dropdown box. (for instance navigator/languages/default character coding)
They're "everywhere".

Comment 6

[Gregory McLean]

This also shows up in the browser itself when scrolling with the mouse wheel.
Same assertions.

Comment 7

[Francisco León]

We need to find out the exact date this regression occured.
I am thinking it was near the 0.9.3 release...

Comment 8

[Christopher Blizzard (:blizzard)]

What's the deal with this?

Comment 9

[R.K.Aa.]

eddies in the timespace continuum?

Comment 10

[Pierre Chanial]

Using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.3+) Gecko/2001081715,

Such Gdk-CRITICAL errors occur only with the classic theme:
- draging quickly the main horizontal and vertical scrollbar with the mouse.
- scrollling with the keyboard
- draging the sidebar vertical bar that enables to modify its horizontal extent
- overlaping a mozilla window with another mozilla one (overlap with a non
mozilla one seem ok)
- loading a new URL
- Shift-reload
- extending the window size (not diminuishing it) 
- so it could be every event that repaint the browsed window.

Error that occurs with the classic, modern and toy factory theme:
Steps to always reproduce:
- start mozilla
- load www.mozilla.org
- CTRL-G
- pop-up "the text you entered was not found"
then Gdk message errors occur
(but it occurs only the first time you tape CTRL-G)

(btw: I couldn't find a bug on thefact that if the search text is empty, and
trying Find again, the Dialog message is "the text you entered was not found"
instead of "You have not entered a text to search.")

Should be > classic and title changed.

Comment 11

[Michael Marxmeier]

With the 2001081514 build (Linux) i can easily trigger 
these messages by simply reading a news message. I am
using the modern theme so this is not specific to classic.

Comment 12

[Pierre Chanial]

I can trigger them too in the newsgroup (installation from scratch).
The differences in the classic/modern theme behaviour concern at least the browser.
So I suggest someone should confirm and file a bug on these.

Comment 13

[Stuart Parmenter]

just add an if (width == 0 || height == 0) return NS_OK;
There are a bunch of dups of this i think.. I'll post a patch tomorrow.

Comment 14

[Jeffrey Baker]

*** Bug 95845 has been marked as a duplicate of this bug. ***

Comment 15

[Karen Huang]

From bug 95845:
This assertion also displays on the console when scrolling down scroll bar from 
the folder pane of the Mail...

Comment 16

[R.K.Aa.]

other actions that triggers it:
-scroll an icon into sight in 3-pane folder-pane
-change focus from browser back to mailnews

strangely, if i have two browser windows open, it is only when changing focus
between the *first* instance of a browser-window and back to mailnews that
triggers the error.

Comment 17

[R.K.Aa.]

*** Bug 97289 has been marked as a duplicate of this bug. ***

Comment 18

[Stuart Parmenter]

Attachment: patch

Comment 19

[Christopher Blizzard (:blizzard)]

I still see errors with this patch.

Comment 20

[Stuart Parmenter]

Attachment: almost real fix

Comment 21

[Stuart Parmenter]

Attachment: real fix

Comment 22

[Stuart Parmenter]

need r= and sr=

Comment 23

[Roland Mainz]

Attachment: New patch, incl. slight enhancements and port to Xlib port

Comment 24

[David Hyatt]

sr=hyatt

Comment 25

[Stuart Parmenter]

Comment on attachment 48050 [details] [diff] [review]
New patch, incl. slight enhancements and port to Xlib port

This can be checked in for 0.9.5.

Comment 26

[Roland Mainz]

pavlov:
I disagree with you.
the comment "I do not like Xlib toolkit" is _NO_ reason to reject the Xlib
patch!

Comment 27

[Brian Ryner (not reading)]

Comment on attachment 48049 [details] [diff] [review]
real fix

r=bryner

Comment 28

[Stuart Parmenter]

the xlib fix is not critical for 0.9.4.

It can be checked in once the tree branches for 0.9.5.

Comment 29

[Asa Dotzler [:asa]]

a=asa

Comment 30

[Stuart Parmenter]

Comment on attachment 48049 [details] [diff] [review]
real fix

checked in

Comment 31

[Roland Mainz]

I am still getting _sporadic_ Gdk-Critical asserts while scrolling pages with
many images (try
http://de.search.yahoo.com/search/photos_de?p={foto}&nice=foto&z=date&n=200).

pavlov:
Thanks for banning me ("*** Closing Link: gisburn[gk1616@255.255.255.255]
(Banned)") while reporting this issue to you. THANKS! ;-(

Comment 32

[Stuart Parmenter]

I'm glad you were very specific as to which gdk-critical errors you are 
receiving.

Comment 33

[Terri Preston]

Roland, are you still seeing this?

Comment 34

[Stuart Parmenter]

marking fixed