951747 - Add simple measurement to BrowserUITelemetry for toolbar contents

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

This has already landed for non-Australis in bug 943606. This bug completes the work for Australis. Probably should have kept bug 943606 open for it, but whatever.

We're interested in collecting:

* The list of default items that are not in their default toolbars
* The list of default items that are in the palette
* The list of non-default items that are not in the palette

We'll be checking for only the built-in default and non-default items. Items supplied by add-ons will be skipped.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: WIP Patch 1

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Gonna do a self review, and then request the real deal.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8349594 [details] [diff] [review]
Patch v1

pew pew pew

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8349594 [details] [diff] [review]
Patch v1

Review of attachment 8349594 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/BrowserUITelemetry.jsm
@@ +22,5 @@
> +XPCOMUtils.defineLazyGetter(this, "DEFAULT_TOOLBAR_PLACEMENTS", function() {
> +  let result = {
> +    // It's true that toolbar-menubar is not visible
> +    // on OS X, but the XUL node is definitely present
> +    // in the document.

Can you move this comment to be located above the "toolbar-menubar" property?

@@ +34,5 @@
> +      "history-panelmenu",
> +      "fullscreen-button",
> +      "find-button",
> +      "preferences-button",
> +      "add-ons-button",

You'll need to update this to include "developer-button" once bug 941002 relands. Can you file a new bug that blocks 941002 to update this?

It doesn't appear that you are worried about the ordering of these items, but maybe that would be interesting to have? If so, you'll want to track bug 951487 which may reorder these placements. It'd be great if these lists didn't have to be separate copies, as they may get out of sync with the actual placements used in CustomizableUI.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d549a25bc029