951857 - Bring back UI entry points and the setup dialog for old sync

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

We removed all that in bug 926709 but we need to bring it back for now to not break old Sync on Desktop when merging elm to m-c soon.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-951857-Bring-back-UI-entry-points-and-the-setup-.patch

Pretty much a straight backout of https://hg.mozilla.org/projects/elm/rev/6774532951f6

The only "collision" was browser/base/content/browser-appmenu.inc because that files doesn't exist anymore as the Firefox menu button is gone now.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8349690 [details] [diff] [review]
0001-Bug-951857-Bring-back-UI-entry-points-and-the-setup-.patch

Review of attachment 8349690 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but really more of a rubber-stamp given the comment about it being a straight-forward backout.

Comment 3

[Nick Alexander :nalexander [he/him] (PTO until Monday, July 28)]

Just to be clear, this should land on elm for testers before merge.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/projects/elm/rev/1e5821e13a77

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/1e5821e13a77

Comment 6

[James Bonacci [:jbonacci]]

Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.