Closed Bug 951883 Opened 6 years ago Closed 6 years ago

Final changes to Android FxAccounts in preparation for elm -> m-c merge

Categories

(Firefox for Android :: Android Sync, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: nalexander, Assigned: nalexander)

Details

(Whiteboard: [fixed in elm][qa+])

This is the Android analogue to Bug 951857.
We'll need to revert the name of the BrowserProvider changed in ee798af61816 (it says Bookmarks now; it should go back to Firefox).

The current code exposes a new Android Account type; that's probably not something we want to display right now.  Unfortunately we can't run-time pref displaying the new Account type, because it's declared in the Android manifest.  So, to maintain our existing Nightly Sync experience best, we should compile-time pref off the Android account type; that requires a little code but will .  This is as easy as compile-time guarding the AndroidManifest.xml.in includes.

Commit 136b8910 introduced some "inverted" compile time guards for chrome resources.  We should compile-time guard these the same as above: it doesn't make sense to have about:accounts without a functional Android account backing it.  Since we want to get rid of about:accounts on Android ASAP and replace it with native UI, there's no point exposing this to non-testers.  People who want to test FxAccounts will continue to use the existing elm builds.

And just for good measure, we'll stop Fennec from listening to FxAccount:* messages.

This will land Bug 889749, expanding our accepted TLS ciphersuite on Android.  We wanted this to land but didn't want to put in the old device testing required before now; this is a net win.
And we'll want to land an elm-only mozconfig change compile-time enabling FxAccounts.
On IRC, me, mfinkle, and gavin decided that no compile-time pref was necessary; so this got simpler.
Summary: Compile-time pref off FxAccounts in preparation for elm -> m-c merge → Final changes to Android FxAccounts in preparation for elm -> m-c merge
+1 to that!
Whiteboard: [fixed in elm] → [fixed in elm][qa+]
https://hg.mozilla.org/mozilla-central/rev/04c636ebe2dc
https://hg.mozilla.org/mozilla-central/rev/1d0f7baa7629
Assignee: nobody → nalexander
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.
Status: RESOLVED → VERIFIED
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.