952080 - Inputmethod.sendKey always returns success, also if the key got canceled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

sendKey always succeeds, even when the keydown got preventDefault'ed. We should implement this properly.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: 952080.diff

Simple patch. If keydown gets canceled there will be no key inserted so the promise should fail.

We need this f.e. in keyboard where we do autocorrect on enter, but if the key event gets canceled that shouldn't happen.

Comment 2

[Yuan Xulei [:yxl] (Leave from May 18)]

Comment on attachment 8350062 [details] [diff] [review]
952080.diff

Review of attachment 8350062 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. And we need a mochitest for this ;-)

::: dom/inputmethod/MozKeyboard.js
@@ +544,5 @@
>        case "Keyboard:SendKey:Result:OK":
>          resolver.resolve();
>          break;
> +      case "Keyboard:SendKey:Result:Error":
> +        resolver.reject();

Reject with the reason why sendKey failed.

::: dom/inputmethod/forms.js
@@ +529,1 @@
>              requestId: json.requestId

We need to return some meaningful error message to let keyboard know why it failed.

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

:janjongboom goes on quest to write test.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch v2 (has tests)

Patch with rejection reason included, and a mochitest.

Try: https://tbpl.mozilla.org/?tree=Try&rev=c95c83a7c234

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

Hi Ryan, does that try look OK? I see some intermittents and a timeout.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

All known issues, yes.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/c0335f9a2498

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c0335f9a2498