Closed Bug 952158 Opened 6 years ago Closed 6 years ago

[Rocketbar] Add clear button

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.3 C1/1.4 S1(20dec)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [c= p=1 s=2013.12.20 u=])

Attachments

(2 files)

46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
A clear button should exist in rocketbar to clear the current input.
Attached file Github pull request
Comment on attachment 8350197 [details] [review]
Github pull request

Can you give this simple one a review? Thanks!
Attachment #8350197 - Flags: review?(21)
Landed: https://github.com/mozilla-b2g/gaia/commit/db9f8c607a4991eaca9fda2ed656459f577af5bd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [c= p=1 s= u=] → [c= p=1 s=2013.12.20 u=]
Attached file Patch follow-up
The original patch introduces a new form which we do not prevent the default of. This patch cleans up some logic to detect form submissions, and prevent the submit default
Attachment #8350639 - Flags: review?(21)
Comment on attachment 8350639 [details] [review]
Patch follow-up

Sorry to not have caught that sooner.
Attachment #8350639 - Flags: review?(21) → review+
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in before you can comment on or make changes to this bug.