Closed
Bug 952158
Opened 12 years ago
Closed 12 years ago
[Rocketbar] Add clear button
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 C1/1.4 S1(20dec)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [c= p=1 s=2013.12.20 u=])
Attachments
(2 files)
A clear button should exist in rocketbar to clear the current input.
| Assignee | ||
Comment 1•12 years ago
|
||
| Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 8350197 [details] [review]
Github pull request
Can you give this simple one a review? Thanks!
Attachment #8350197 -
Flags: review?(21)
Attachment #8350197 -
Flags: review?(21) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [c= p=1 s= u=] → [c= p=1 s=2013.12.20 u=]
| Assignee | ||
Comment 4•12 years ago
|
||
The original patch introduces a new form which we do not prevent the default of. This patch cleans up some logic to detect form submissions, and prevent the submit default
| Assignee | ||
Updated•12 years ago
|
Attachment #8350639 -
Flags: review?(21)
Comment 5•12 years ago
|
||
Comment on attachment 8350639 [details] [review]
Patch follow-up
Sorry to not have caught that sooner.
Attachment #8350639 -
Flags: review?(21) → review+
| Assignee | ||
Comment 6•12 years ago
|
||
Updated•12 years ago
|
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•