952164 - [B2G][Camera] Camera on lock screen allows user to take picture after clicking thumbnail preview despite no camera button being present

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Brogan Zumwalt [Inactive]]

Description:
After accessing the camera from a passcode enabled lock screen, taking a picture then clicking on the thumbnail preview takes the user to a full screen preview of the image. On this screen, if the user presses the area where the "take picture" camera icon was on the previous screen, they are able to take additional pictures despite no camera button being present.

Repro Steps:
1) Updated Buri to Build ID: 20131219004002
2) Open settings app and ensure that both lock screen and passcode lock are enabled for Screen Lock
3) Lock screen by pressing power button on top of phone
4) Press power button again to bring up lock screen
5) Tap camera icon
6) Take picture
7) Select thumbnail preview
8) Tap area where "take picture" button was located on camera screen

Actual:
User is able to take pictures on image preview screen from lock screen camera.

Expected:
User is only able to take pictures on camera screen.

Environmental Variables
Device: Buri v 1.3 Mozilla RIL
Build ID: 20131219004002
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/809aabadac6d
Gaia: a99249a7fdf9f20850d98a9a222385676d472362
Platform Version: 28.0a2
Firmware Version: V1.2_US_20131115


Notes:
Repro frequency: 3/3, 100%
See attached: video clip - http://www.youtube.com/watch?v=3dT9bLVZFyQ

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.2?

Comment 2

[Brogan Zumwalt [Inactive]]

Issue does NOT reproduce on 1.2

Result: User is only able to take pictures on camera screen.

Environmental Variables
Device: Buri v 1.2 COM RIL
Build ID: 20131219004002
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/7958c38c7afd
Gaia: c82c957e9d4078cd4043de6b7d21a2667a73adf7
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_US_20131115

Comment 3

[Jason Smith [:jsmith]]

Sounds like a lovely easter egg. But seriously, we really shouldn't be taking pictures without the user realizing it. That's a privacy problem.

Comment 4

[Matthew Vaughan]

This issue started reproducing on the first 1.3 build from 9/19.

Environmental Variables:
Device: Buri v1.3 MOZ RIL
BuildID: 20130919040201
Gaia: 0dedb5b3789afc638a0c7c67652937fcb30e77d2
Gecko: 803189f35921
Version: 27.0a1
Firmware Version: 20131115

Comment 5

[Jason Smith [:jsmith]]

Does this reproduce on the 9/16 1.2 build?

Comment 6

[Hema Koka [:hema]]

Wilson - Can you check this on latest 1.3 and see whats going on

Comment 7

[Wilson Page [:wilsonpage]]

I have checked out the v1.3 branch and flashed to my Hamachi. I was unable to reproduce the issue and camera worked as expected.

My Hamachi is reporting the following versions:

Gaia      ee5560ab86103701a5d046ef31d46e6c1e026355
Gecko     http://hg.mozilla.org/mozilla-central/rev/bc8c1eb0f2ba
BuildID   20131111040200
Version   28.0a1
ro.build.version.incremental=eng.zxliu.20131101.143946
ro.build.date=Fri Nov  1 14:40:04 CST 2013

Should I be using a different build?

Comment 8

[Hema Koka [:hema]]

Wilson, Earlier comments say it was reproducible on Buri and the firmware version V1.2_US_20131115. I don't remember if you have a Buri -- can you try it on that if you have it.

QA, are you guys able to replicate this issue on hamachi? If so, please add the details here.

Comment 9

[Matthew Vaughan]

(In reply to Wilson Page from comment #7)
> I have checked out the v1.3 branch and flashed to my Hamachi. I was unable
> to reproduce the issue and camera worked as expected.
> 
> My Hamachi is reporting the following versions:
> 
> Gaia      ee5560ab86103701a5d046ef31d46e6c1e026355
> Gecko     http://hg.mozilla.org/mozilla-central/rev/bc8c1eb0f2ba
> BuildID   20131111040200
> Version   28.0a1
> ro.build.version.incremental=eng.zxliu.20131101.143946
> ro.build.date=Fri Nov  1 14:40:04 CST 2013
> 
> Should I be using a different build?

This issue reproduces for me on the 12/23 1.3 MOZ RIL build on a Buri. Some spamming of the area where the camera button would be is needed to reproduce the issue. This seems to be indicated by the attached YouTube video at least.

(In reply to Hema Koka [:hema] from comment #8)
> QA, are you guys able to replicate this issue on hamachi? If so, please add
> the details here.

As far as we, Qanalysts, understand it, Buri and Hamachi are one and the same... an Alcatel One Touch Fire. Is this correct?

Comment 10

[Matthew Vaughan]

This issue does reproduce on the 9/16 1.2 build. 

I tested further back and this issue reproduces on the 8/17 1.2 build for me, which seems to be when the feature of accessing the camera from the pin protected lock screen was first implemented.

- Unable to access camera (Works) -
Environmental Variables:
Device: Buri v1.2 MOZ RIL
BuildID: 20130816040203
Gaia: be95c3b6757290fff4fdde7a2b73c68f599131a1
Gecko: 6f265af4e3d8
Version: 26.0a1
Firmware Version: V1.2_US_20131115

- Broken -
Environmental Variables:
Device: Buri v1.2 MOZ RIL
BuildID: 20130817040203
Gaia: 2cad0ff0180e0b33ac49aed3030949e6edbda95d
Gecko: 8ad1e4c838c8
Version: 26.0a1
Firmware Version: V1.2_US_20131115

Comment 11

[Wilson Page [:wilsonpage]]

Attachment: Pull Request

Comment 12

[Hema Koka [:hema]]

Update from 1/8 triage: marking this a blocker, broken behavior

Comment 13

[Diego Marcos [:dmarcos]]

Has this landed?

Comment 14

[Diego Marcos [:dmarcos]]

I've seen the patch. it seems that there are merge conflicts. Wilson, can you rebase the patch and push again to update the PR?

Comment 15

[Tony Nguyen]

This issue seems to have been fixed, however there appears to be a new issue with taking a photo from the lockscreen. When taking a photo from the lockscreen without a passcode enabled, the UI will display a "Retake" and "Select button. The new issue has been logged in bug 959301.

Comment 16

[Wilson Page [:wilsonpage]]

dmarcos: fixed conflicts. The issue was not related to the app being launched from the lock screen, but the fact that the image preview didn't contain the share and delete icons that normally captured clicks in that region.

Comment 17

[Diego Marcos [:dmarcos]]

I see lint errors in the PR

----- FILE : /home/travis/build/mozilla-b2g/gaia/apps/camera/js/filmstrip.js -----

Line 67, E:0002: Missing space before "{"

Comment 18

[Wilson Page [:wilsonpage]]

dmarcos: Fixed, apologies. Won't happen again now I have that linting fixed on my machine.

Comment 19

[Diego Marcos [:dmarcos]]

I looked at the patch and I don't understand how this works. It seems that the "thumbnail preview" event gets propagated to the shutter button because both elements overlap. It wouldn't be necessary to also do event.stopPropagation() in the preview.onclick?

The really clean solution for this would be hiding the controls when the user is inspecting the thumbnails (filmstrip inspecting mode?)

Comment 20

[Wilson Page [:wilsonpage]]

I couldn't workout the cause of the bug, but found out that somehow clicks were propagating to separate DOM sub-tree, as if they were bubbling up the the same tree. Adding a click event to the target (or target's parent) prevented this behaviour.

Comment 21

[Diego Marcos [:dmarcos]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/2ada1e2f80e2cdbf49ba0868919a9eb565c4b605

Comment 22

[Wilson Page [:wilsonpage]]

I just realised this has to land in 1.3 as well. Going to prepare a 1.3 patch too.

Comment 23

[Wilson Page [:wilsonpage]]

Attachment: v1.3 Patch

Comment 24

[Ryan VanderMeulen [:RyanVM]]

v1.3: 79ee4891c7d744251ec1dbcb6ae23e7fff1b8205