952336 - Switch-to-tab on the current tab does not reshow web content

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Patch #2 in bug 951776 fixes this for 26. This bug is specifically for 27, which should be fixed with a similar patch.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Explicit STR:
1) Go to apple.com
2) Click URL bar, type "apple"
3) Select switch-to-tab

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

26 will be fixed in bug 951776 (https://hg.mozilla.org/releases/mozilla-release/rev/1445a7e883c5).

Sorry that I made this confusing.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note to self: write some test cases.

Comment 4

[Aaron Train [:aaronmt]]

Let's change this to fixed since it landed on the branch.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Aaron Train [:aaronmt] from comment #4)
> Let's change this to fixed since it landed on the branch.

via bug 951776.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Test switch-to-tab from the bookmarks/history lists too!

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Switch-to-tab on the current tab properly reshows web content.

Basically patch #2 from bug 951776. Note this relies on the patch in bug 952343 to work (only due to the added comment though).

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Marked blocking for the dependency mentioned in comment 7.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8350414 [details] [diff] [review]
Switch-to-tab on the current tab properly reshows web content.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Unknown.

User impact if declined: 
  Hitting switch-to-tab from a page to itself will not return to the web content properly.

Testing completed (on m-c, etc.):
  Similar patch into release yesterday (bug 951776), similar patches on 28 and 29 for at least a month
 
Risk to taking this patch (and alternatives if risky):
  Medium, since we're playing with changing the visibility of essential views, in the worst case, this bricks the browser until a force stop. However, this patch is similar to those we done before and so I'm confident it will not be all that problematic.
 
String or IDL/UUID changes made by this patch:
  None

Note that bug 952343 needs to be uplifted first.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/82b238f279dd

Comment 11

[Flaviu Cos]

Verified as fixed in builds:
- 26;
- 27 beta 6; 
Device: Google Nexus 7 (Android 4.4.2);