Closed
Bug 952343
Opened 10 years ago
Closed 10 years ago
Dismissing editing mode (back button) started from web content will not return to web content
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox26 verified, firefox27 verified, firefox28 unaffected, fennec27+)
VERIFIED
FIXED
Firefox 27
Tracking | Status | |
---|---|---|
firefox26 | --- | verified |
firefox27 | --- | verified |
firefox28 | --- | unaffected |
fennec | 27+ | --- |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
(Keywords: reproducible)
Attachments
(1 file)
1.36 KB,
patch
|
sriram
:
review+
bajaj
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
1) Go to a page (e.g. apple.com) 2) Click the url bar 3) Type anything (e.g. "aoeu") 4) Tap back twice Expected: The page is shown Actual: A broken HomePager is shown The ordering of hideBrowserSearch and hideHomePager should be switched in dismissEditingMode. This affects 27 and is working after the patches in bug 951776 on 26 (but I'm not sure if it was ever broken). Note to self: write some test cases.
Assignee | ||
Updated•10 years ago
|
Updated•10 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Comment 1•10 years ago
|
||
via bug 951776.
Assignee | ||
Comment 2•10 years ago
|
||
Taken from part of patch 1 in bug 951776. Also makes the code more like trunk.
Attachment #8350413 -
Flags: review?(sriram)
Updated•10 years ago
|
Attachment #8350413 -
Flags: review?(sriram) → review+
Updated•10 years ago
|
tracking-fennec: ? → 27+
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8350413 [details] [diff] [review] Dismissing editing mode properly returns to web content. [Approval Request Comment] Bug caused by (feature/regressing bug #): Unknown. User impact if declined: Hitting the back button in editing mode with text typed will not return to the web content properly. Testing completed (on m-c, etc.): Similar patch into release yesterday (bug 951776), similar patches on 28 and 29 for at least a month Risk to taking this patch (and alternatives if risky): Medium, since we're playing with changing the visibility of essential views, in the worst case, this bricks the browser until a force stop. However, this patch is similar to those we done before and so I'm confident it will not be all that problematic. String or IDL/UUID changes made by this patch: None
Attachment #8350413 -
Flags: approval-mozilla-beta?
Updated•10 years ago
|
Keywords: reproducible
Updated•10 years ago
|
Attachment #8350413 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 4•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/7d87682913a9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Comment 5•10 years ago
|
||
I am not able to reproduce the bug using the following devices: - Google Nexus 7 (Android 4.4.2); - Samsung Galaxy S (Android 2.3.4); - Samsung Galaxy Nexus (Android 4.2.1). Feel free to open it again or a new one if you will see the wrong behavior again.
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•