952423 - [Download Manager] Error message should be "No memory card found" (consistency with existing strings)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Francesco Lodolo [:flod]]

As explained in bug 948979 comment 4

> no_sdcard_download_message = No memory card inserted

The usual message in Gaia is "No memory card found", not "inserted".
http://mxr.mozilla.org/l10n-gaia/search?string=no%2Bmemory%2Bcard%2Bfound&find=en-US

Please use a new ID for the updated string (probably not strictly necessary in this case, but still better).

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8350545 [details]
Patch v1

Switching to feedback, not sure it's right for me to do reviews. 
Too bad we need to change 3 strings, but patch looks OK to me.

Comment 3

[Cristian Rodriguez (:crdlc)]

(In reply to Francesco Lodolo [:flod] from comment #2)
> Comment on attachment 8350545 [details]
> Patch v1
> 
> Switching to feedback, not sure it's right for me to do reviews. 
> Too bad we need to change 3 strings, but patch looks OK to me.

Yes, because for each kind of UI we have an id (I had to change the title, message and button id for no-sdcard UI)

Comment 4

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/68cf8c64433ee5b11ca7a742dd0d3505d5144911