952625 - make tab streaming support scrolling and other goodies

Status: RESOLVED WORKSFORME

(Core :: WebRTC, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: nsITabSource.idl

It'd be very nice for add-ons to be able to experiment with a variety of tab-streaming UIs.  After discussion with Brad, I'm attaching a proposed API change which would allow this.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8350756 [details]
nsITabSource.idl

Sorry, mean to comment on this a couple weeks ago. Turns out our params are a terrible thing in js and optional out params create even more head aches.

I can see two options. First, crate an interface that has the nsIDOMWindow, render flags and clip rect and return that. Second have an options TabStreamOptions interface that is an inout param.

Let me know what you think dmose.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Would the easiest thing simply be to make the parameters mandatory rather than optional?  Making IDL equivalents of the nsIPresShell.h stuff sounds worthwhile.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

(The short version is that I don't have super strong opinions here.  Just getting something that works, whatever the interface, would be wonderful).

Comment 4

[Mike de Boer [:mikedeboer]]

This is already supported by the built-in window sharing implementation:

mozGetUserMedia({
  videoSource: "browser",
  constraints: {
    browserWindow: 42,
    scrollWithPage: true
  }
});

Note the `scrollWithPage` constraint.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

That syntax looks odd, did you mean:

    navigator.mediaDevices.getUserMedia({ video:
      {
        mediaSource: "browser",
        browserWindow: 42,
        scrollWithPage: true
      }
    });

Comment 6

[Mike de Boer [:mikedeboer]]

(In reply to Jan-Ivar Bruaroey [:jib] from comment #5)
> That syntax looks odd, did you mean:
> 
>     navigator.mediaDevices.getUserMedia({ video:
>       {
>         mediaSource: "browser",
>         browserWindow: 42,
>         scrollWithPage: true
>       }
>     });

Ahum! Yes, thanks Jan-Ivar, the option passing from Loop -> OpenTok SDK -> gUM is confusing me, obviously.