Closed Bug 952817 Opened 6 years ago Closed 6 years ago

VariablesView.createHierarchy should always be called when the view is emptied

Categories

(DevTools :: Object Inspector, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

There are no other realistic scenarios of this method being useful apart from when clearing the variables view.

I think it should also be private, to avoid having clients need to think about it specifically.
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8350980 - Flags: review?(bbenvie)
Friendly review ping :)
Flags: needinfo?(bbenvie)
Priority: -- → P3
Blocks: 951795
Making this a P2 because it block another bug which blocks a bunch of other bugs.
Priority: P3 → P2
Comment on attachment 8350980 [details] [diff] [review]
v1

Review of attachment 8350980 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, Christmas! This is all straightforward, LGTM.
Attachment #8350980 - Flags: review?(bbenvie) → review+
Flags: needinfo?(bbenvie)
https://hg.mozilla.org/mozilla-central/rev/641671b50e97
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.