Closed Bug 952905 Opened 6 years ago Closed 6 years ago

"Move to Menu" and "Menu Bar" share access key

Categories

(Firefox :: Toolbars and Customization, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: jkitch, Assigned: jkitch)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [Australis:P4][good first verify])

Attachments

(1 file, 1 obsolete file)

Right click on the toolbar or tab area.
"Menu Bar" and "Move to Menu" have the same access key (M)

Is this desirable?

Other similar menu items (open link, close tab and view page source/info) manage to have unique access keys
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 952742
Egh, actually, I should have read better. This is a separate issue. Dolske? (NB: there won't be a "Menu bar" entry on OS X, but it'll conflict on Windows and Linux...)
Status: RESOLVED → REOPENED
Flags: needinfo?(dolske)
Resolution: DUPLICATE → ---
Status: REOPENED → NEW
Whiteboard: [Australis:P4]
Oh, nuts. I guess the simple fix would be to just change the accesskey to "o" for "Move to Menu" and "Move to Toolbar". (Not sure if that needs an entity change for L10N?)
Flags: needinfo?(dolske)
Attached patch move.diff (obsolete) — Splinter Review
Changed according to comment 3.

I've added a localisation note warning as the problem also affects es-CL and pt-PT.  Do they need follow up bugs?
Assignee: nobody → jkitch.bug
Status: NEW → ASSIGNED
Attachment #8356430 - Flags: review?(jaws)
Comment on attachment 8356430 [details] [diff] [review]
move.diff

(In reply to James Kitchener (:jkitch) from comment #4)
> I've added a localisation note warning as the problem also affects es-CL and
> pt-PT.  Do they need follow up bugs?

Yes, please file bugs for them: https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Localizations
Attachment #8356430 - Flags: review?(jaws) → review+
Keywords: checkin-needed
Attached patch move.diffSplinter Review
Land this one instead.

Localisation note now also warns of the potential for clashes with personalbarCmd (Bookmark toolbar), which occurs in the 'it' locale.
Attachment #8356430 - Attachment is obsolete: true
Blocks: 957076
https://hg.mozilla.org/integration/fx-team/rev/6a99a1f08e62
Keywords: checkin-needed
Whiteboard: [Australis:P4] → [Australis:P4][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/6a99a1f08e62
Status: ASSIGNED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][fixed-in-fx-team] → [Australis:P4]
Target Milestone: --- → Firefox 29
Whiteboard: [Australis:P4] → [Australis:P4][good first verify]
You need to log in before you can comment on or make changes to this bug.