952905 - "Move to Menu" and "Menu Bar" share access key

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[James Kitchener (:jkitch)]

Right click on the toolbar or tab area.
"Menu Bar" and "Move to Menu" have the same access key (M)

Is this desirable?

Other similar menu items (open link, close tab and view page source/info) manage to have unique access keys

Comment 2

[:Gijs (out for now; he/him)]

Egh, actually, I should have read better. This is a separate issue. Dolske? (NB: there won't be a "Menu bar" entry on OS X, but it'll conflict on Windows and Linux...)

Comment 3

[Justin Dolske [:Dolske]]

Oh, nuts. I guess the simple fix would be to just change the accesskey to "o" for "Move to Menu" and "Move to Toolbar". (Not sure if that needs an entity change for L10N?)

Comment 4

[James Kitchener (:jkitch)]

Attachment: move.diff

Changed according to comment 3.

I've added a localisation note warning as the problem also affects es-CL and pt-PT.  Do they need follow up bugs?

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8356430 [details] [diff] [review]
move.diff

(In reply to James Kitchener (:jkitch) from comment #4)
> I've added a localisation note warning as the problem also affects es-CL and
> pt-PT.  Do they need follow up bugs?

Yes, please file bugs for them: https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Localizations

Comment 6

[James Kitchener (:jkitch)]

Attachment: move.diff

Land this one instead.

Localisation note now also warns of the potential for clashes with personalbarCmd (Bookmark toolbar), which occurs in the 'it' locale.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/6a99a1f08e62

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6a99a1f08e62