952922 - Change Makefile rule dependencies to generate applications-data before building individual apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, enhancement)

Description

[Diego Marcos [:dmarcos]]

The camera app need the data generated by the applications-data rule during the building process.

Comment 1

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8351169 [details] [review]
Pull Request

r=yurenju, looks more reasonable, thank you Diego!

Comment 3

[Diego Marcos [:dmarcos]]

Why is this bug depending on https://bugzilla.mozilla.org/show_bug.cgi?id=957857?

Comment 4

[Jason Smith [:jsmith]]

(In reply to Diego Marcos from comment #3)
> Why is this bug depending on
> https://bugzilla.mozilla.org/show_bug.cgi?id=957857?

See https://bugzilla.mozilla.org/show_bug.cgi?id=957857#c4. This bug was suspected for causing this regression, but looking at this further, I don't think that's possible, as this bug only landed on 1.4.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Diego, Do you still need to execute applications-data.js before app-makefile? I saw you have build.js in camera/build to generate js/config.js which is same as applications-data.js.

Comment 6

[Diego Marcos [:dmarcos]]

Yes because build/configure.js is a node script and tbpl environment doesn't have node.js. We still rely on the applications-data.js script for the tbpl builds. If you manage to make node available in tbpl then we can get rid of the camera specific code inside applications-data.js and we wouldn't care about the applications-data rule in the main Makefile.

The configure.js script is just a first step to make the camera build process independent from the main Makefile.