Closed Bug 953150 Opened 7 years ago Closed 7 years ago
[DSDS] Unable to Reset PIN2 from FDN menu
Attached patch fixes this issue. Please review
Status: UNCONFIRMED → ASSIGNED
blocking-b2g: --- → 1.3+
Ever confirmed: true
Hi kaze and ehung, Please provide feedback on this.
Fabien, did you get a chance to review the fix for this bug?
Comment on attachment 8351482 [details] pr.html Redirect to Arthur, since he knows more on SIM2 and FDN.
Attachment #8351482 - Flags: review?(ehung) → review?(arthur.chen)
Comment on attachment 8351482 [details] pr.html OMG, good catch!
Hmm, looks like I’ve merged this too fast. It’s a regression of bug 928295: the `options' argument of the `show()' method was optional, but the patch provided for bug 928295 made it mandatory.
Back-out: https://github.com/mozilla-b2g/gaia/commit/beb7180 Stealing.
Assignee: poojas → kaze
Attachment #8351482 - Flags: review+ → review-
Arthur, Please help provide your input on the review at the earliest.
Comment on attachment 8357151 [details] [review] patch r=me. Thanks!
Attachment #8357151 - Flags: review?(arthur.chen) → review+
Uplifted 8abf6df115305809c8b1e79e62834fb0a5b4c3aa to: v1.3: dc36d5dbf966891bfdbbfd9821f07aafbf484a38
Flags: in-moztrap? → in-moztrap+
You need to log in before you can comment on or make changes to this bug.