953408 - Unprefix -moz-hyphens

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[sjw]

Gecko has a very well working hyphenation and this part of the spec looks stable enough. So we should remove the prefix.

Comment 1

[David Baron :dbaron:]

Does the last call issues list for the spec look like it's not going to lead to hyphenation-related changes?

Comment 2

[sjw]

Last hyphenation-related changes were from 1 September 2011 to 19 January 2012: http://www.w3.org/TR/2012/WD-css3-text-20120119/#recent-changes
Firefox supports the current spec.

There are no hyphenation-related bugs or testcases:
http://www.w3.org/Style/CSS/Tracker/products/10
http://test.csswg.org/suites/css3-text/nightly-unstable/html/chapter-6.htm

Comment 3

[John Daggett (:jtd)]

Attachment: patch, unprefix -moz-hyphens property

Unprefix the -moz-hyphens property and add a temporary alias for -moz-hyphens ==> hyphens. Conversions of existing tests done in a separate patch.

Comment 4

[John Daggett (:jtd)]

Attachment: patch, unprefix -moz-hyphens property in tests

Switch tests to use unprefixed hyphens property

Comment 5

[John Daggett (:jtd)]

This property and it's property value definitions have been stable for a while and implemented in prefixed form across IE/Webkit/Gecko for some time. Only Chrome lacks support for this.

Our implementation includes support for a wide set of languages and I don't see any significant bug logged against hyphenation currently. I think we should do the unprefixing for the FF43 release.

Comment 6

[John Daggett (:jtd)]

Attachment: patch, unprefix -moz-hyphens property

Fix up minor omission in property_database.js, need to include alias explicitly.

Comment 7

[John Daggett (:jtd)]

CSS3 Text description of 'hyphens':
http://www.w3.org/TR/css-text-3/#hyphenation

MDN page:
https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens

Comment 8

[Cameron McCormack (:heycam)]

(In reply to John Daggett (:jtd) from comment #5)
> This property and it's property value definitions have been stable for a
> while and implemented in prefixed form across IE/Webkit/Gecko for some time.
> Only Chrome lacks support for this.
> 
> Our implementation includes support for a wide set of languages and I don't
> see any significant bug logged against hyphenation currently. I think we
> should do the unprefixing for the FF43 release.

Given all this, and that there have still been no changes to css-text-3 about hyphenation since the Last Call, and there are no open issues on it, I think it's safe to unprefix.

Can you send an Intent to Ship mail to dev-platform about this?  https://wiki.mozilla.org/WebAPI/ExposureGuidelines is geared towards DOM APIs, but we tend to use it for CSS features too (e.g. see Mats' display:contents Intent to Ship mail from a few months ago, for example).  I don't expect anyone to have problems with this.  I suggest mentioning in the mail that you plan to enable this at the end of this week, just to give people a few days to respond.

Comment 9

[John Daggett (:jtd)]

(In reply to Cameron McCormack (:heycam) from comment #8)

> Can you send an Intent to Ship mail to dev-platform about this? 
> https://wiki.mozilla.org/WebAPI/ExposureGuidelines is geared towards DOM
> APIs, but we tend to use it for CSS features too (e.g. see Mats'
> display:contents Intent to Ship mail from a few months ago, for example).  I
> don't expect anyone to have problems with this.  I suggest mentioning in the
> mail that you plan to enable this at the end of this week, just to give
> people a few days to respond.

Yes, planning to do exactly this sometime this week!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3994cb9aa50
https://hg.mozilla.org/integration/mozilla-inbound/rev/583b3c9b6e0e

Comment 11

[John Daggett (:jtd)]

Intent to unprefix message:
https://lists.w3.org/Archives/Public/www-style/2015Sep/0115.html

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3994cb9aa50
https://hg.mozilla.org/mozilla-central/rev/583b3c9b6e0e

Comment 13

[Kohei Yoshino]

Added the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/hyphens-property-has-been-unprefixed/

Comment 14

[sjw]

Thanks for fixing! I just updated the docs:
https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens
https://developer.mozilla.org/en-US/Firefox/Releases/43

Comment 15

[sjw]

Is it already to late for a relnote?

Release Note Request (optional, but appreciated)
[Why is this notable]:
Notable change for WebDevs

[Suggested wording]:
Support for unprefixed 'hyphens' property

[Links (documentation, blog post, etc)]:
https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens

Comment 16

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

I just added it, thanks!