953964 - Provide UI to open about:crashes and about:support

Status: RESOLVED DUPLICATE of bug 955438

(Instantbird Graveyard :: Other, enhancement)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 526 at 2010-09-28 22:26:00 UTC ***

about:crashes and about:support are very useful in diagnosing problems and should be available to end users when we're offering support.  End users should not have to open the error console and type in "scary code" in order to get to these dialogs. They can be opened with:
openDialog("about:crashes");
openDialog("about:support");

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 526 at 2010-11-01 13:06:47 UTC ***

Started some work on this. Should have a first patch up soon.

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 526 at 2010-11-01 16:30:34 UTC ***

How does the proposed UI addition look like?

Comment 3

[Patrick Cloke [:clokep]]

*** Original post on bio 526 at 2010-11-01 19:40:51 UTC ***

I was going to add a separator under check for updates and then a "Troubleshooting Information" for about:support and a "Crash Log" for about:crashes, above the separator for "About Instantbird."

I figured I'd keep it simple. Do you think there's a better way to integrate this?

Comment 4

[Benedikt Pfeifer]

*** Original post on bio 526 at 2010-11-01 21:20:38 UTC ***

(In reply to comment #3)
> I was going to add a separator under check for updates and then a
> "Troubleshooting Information" for about:support and a "Crash Log" for
> about:crashes, above the separator for "About Instantbird."
> 
> I figured I'd keep it simple. Do you think there's a better way to integrate
> this?

Firefox 4 will have a menu item to "Restart with Add-ons Disabled" in the Help menu. Since this is part of the standard procedure when someone encounters a bug it makes sense for us to include it as well.

Comment 5

[Florian Quèze [:florian]]

*** Original post on bio 526 at 2010-11-01 21:30:05 UTC ***

(In reply to comment #3)
> I was going to add a separator under check for updates and then a
> "Troubleshooting Information" for about:support and a "Crash Log" for
> about:crashes, above the separator for "About Instantbird."

What's included in about:support?
"Troubleshooting Information" sounds fine for a menu item in the "help" menu. I don't really like "Crash log" as it suggests that Instantbird crashes and may threaten some people who have never and won't encounter any crash. Can't the about:crashes thing be included in the about:support page with an explanation of what it is?
I haven't seen what about:support looks like yet so this may be a stupid suggestion.

Comment 6

[Patrick Cloke [:clokep]]

Attachment: about:support from Firefox

*** Original post on bio 526 as attmnt 394 at 2010-11-01 21:55:00 UTC ***

about:support from my Firefox nightly.

I think next to "Copy all to clipboard" we could have a "Show crash logs"? Or maybe we can just add a table that has them there (possibly with a +/- to show hide the section).

I think you're right flo that this would be a better place for it.

Comment 7

[Florian Quèze [:florian]]

*** Original post on bio 526 at 2010-11-01 23:08:43 UTC ***

Thanks for adding the screenshot to clarify things :-).
I suspect having a "pastebin" button there would be even more helpful than "copy to clipboard" ;-).

What about a table with a label "Recent crashes" with the content of the about:crashes page? (maybe we can use about:crashes in an iframe?) Maybe it should only display the crashes that happened in the last month.

Comment 8

[Patrick Cloke [:clokep]]

*** Original post on bio 526 at 2010-11-02 16:00:02 UTC ***

(In reply to comment #7)
> Thanks for adding the screenshot to clarify things :-).
> I suspect having a "pastebin" button there would be even more helpful than
> "copy to clipboard" ;-).
Maybe, but I'd include that as part of bug 953965 (bio 527).

> What about a table with a label "Recent crashes" with the content of the
> about:crashes page? (maybe we can use about:crashes in an iframe?) Maybe it
> should only display the crashes that happened in the last month.
I think the iframe way would be the best way with minimal work by us. (And again I would include this in bug 953965 (bio 527) then).

Comment 9

[Patrick Cloke [:clokep]]

Attachment: Patch to add about:support

*** Original post on bio 526 as attmnt 408 at 2010-12-03 19:21:00 UTC ***

This patch adds about support. I'm sure it'll need a little work, but requesting an initial review.

Comment 10

[Patrick Cloke [:clokep]]

Attachment: Patch to add about:support

*** Original post on bio 526 as attmnt 409 at 2010-12-03 19:32:00 UTC ***

Oops,I had uploaded my patch from bug 953984 (bio 546), not this one. Thanks for noticing Mic.

Comment 11

[Patrick Cloke [:clokep]]

Comment on attachment 8352151 [details] [diff] [review]
Patch to add about:support

*** Original change on bio 526 attmnt 408 at 2010-12-03 19:32:19 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 12

[Florian Quèze [:florian]]

Comment on attachment 8352152 [details] [diff] [review]
Patch to add about:support

*** Original change on bio 526 attmnt 409 at 2010-12-03 21:59:05 UTC ***

>diff --git a/instantbird/content/menus.js b/instantbird/content/menus.js

>+const supportWindow = "chrome://global/content/aboutSupport.xhtml";
 
>+  support: function menu_support() {
>+    if (!this.focus("Messenger:Support"))

The parameter should be the value of the windowtype attribute of the window tag of the XUL document.
I'm not sure but I don't think you can use this successfully with an (X)HTML document.

>diff --git a/instantbird/content/menus.xul.inc b/instantbird/content/menus.xul.inc
>--- a/instantbird/content/menus.xul.inc
>+++ b/instantbird/content/menus.xul.inc
>@@ -133,16 +133,21 @@
> #endif
> #ifndef XP_MACOSX
>       <menupopup id="helpMenuPopup" onpopupshowing="menus.displayUpdateStatus();">
>         <menuitem id="updatesMenuItem" label="&checkForUpdates;" oncommand="menus.updates()"/>
>         <menuseparator/>
> #else
>       <menupopup id="helpMenuPopup">
> #endif
>+        <menuitem id="support" label="&support.menu;" oncommand="menus.support()"/>
>+# #ifdef MOZ_CRASHREPORTER
>+#        <menuitem id="crashes" label="&crashes.menu;" oncommand="menus.crashes()"/>
>+# #endif
>+        <menuseparator/>

The "Help" menu is currently not visible on Mac, the "About" item is moved automatically to the application menu.

Comment 13

[Patrick Cloke [:clokep]]

*** Original post on bio 526 at 2011-10-27 00:09:21 UTC ***

Removing myself from assignee.

Comment 14

[Patrick Cloke [:clokep]]

*** Original post on bio 526 at 2013-07-01 20:33:55 UTC ***

This was fixed by adding an /about command in bug 955438 (bio 2002) that opens these pages in tabs.