954662 - Join/part messages should be handled by imConversations.js.

Status: NEW

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 1230 at 2012-01-07 23:49:00 UTC ***

imConversations.js should handle join/part/quit messages so all messages are unified across JS and libpurple protocols. (This also means we don't have to have each JS proto implement these messages separately!)

Potential Gotchas:
 - Join messages are not wanted until a user is just joining a room.
 - Certain protocols (Twitter) might not want this at all.

libpurple:
 - join: http://lxr.instantbird.org/instantbird/source/purple/libpurple/conversation.c#1729
 - nick changes: http://lxr.instantbird.org/instantbird/source/purple/libpurple/conversation.c#1842
 - left: http://lxr.instantbird.org/instantbird/source/purple/libpurple/conversation.c#1926

Join messages take an "extra message" field, left messages can take a reason.  There are also messages when people are kicked, etc. I'm not sure if this can be put into the left message somehow, or if we want to have separate kick/ban messages too.

Also all the messages need to have a "You" version ("You joined the room", "You left the room", "You are now known as".)

Comment 1

[aleth [:aleth]]

*** Original post on bio 1230 at 2012-06-18 10:24:38 UTC ***

Also topic-change system messages (nb: twitter does not have these and is possibly a special case).

Comment 2

[aleth [:aleth]]

*** Original post on bio 1230 at 2012-06-19 12:41:03 UTC ***

(In reply to comment #1)
> Also topic-change system messages (nb: twitter does not have these and is
> possibly a special case).

Now handled by bug 954950 (bio 1518).

Comment 3

[aleth [:aleth]]

*** Original post on bio 1230 at 2012-06-29 08:58:37 UTC ***

This would also make it possible to optionally hide them (often requested).