955075 - socket.jsm based protocols should connect through HTTP proxies

Status: NEW

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 1646 at 2012-08-14 12:33:00 UTC ***

+++ This bug was initially created as a clone of Bug #954781 (bio 1347) +++
Bug 954781 (bio 1347) has a lot of information on this, but things to try:
http://mxr.mozilla.org/comm-central/source/mozilla/netwerk/base/public/nsIProtocolProxyService.idl#77 [1]

We would need access (or someone with access) to an HTTP proxy to test this.

[1] http://log.bezut.info/instantbird/120719/#m232

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 1646 at 2012-08-14 12:33:50 UTC ***

Also, this is a regression from libpurple based accounts.

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Theoretical patch

*** Original post on bio 1646 as attmnt 2320 at 2013-04-04 17:42:00 UTC ***

It seems like we'd need to do something like [1], which is what this patch does. I have no HTTP Proxy to test this on.

Florian finds it unlikely we have to do the CONNECT ourselves...but I can only find it in HTTP classes [2][4], maybe we can use one of those though, I don't know. [3] also sounds like it would do exactly what we want, but I think we tested that already?

[1] http://mxr.mozilla.org/comm-central/source/mozilla/extensions/irc/js/lib/connection-xpcom.js#408
[2] http://mxr.mozilla.org/mozilla-central/search?string=[^S]CONNECT[^IE_TO\%29\%28%3B]&regexp=1&case=1&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
[3] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIProtocolProxyService.idl#58
[4] http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp

Comment 4

[Patrick Cloke [:clokep]]

*** Original post on bio 1646 at 2013-04-04 17:50:31 UTC ***

Comment on attachment 8354086 [details] [diff] [review] (bio-attmnt 2320)
Theoretical patch

>--- modules\socket - Copy.jsm	2009-12-31 23:00:00.000000000 -0500
>@@ -496,16 +490,26 @@
>     if (!this._outputStream)
>       throw "Error getting output stream.";
> 
>+    // The output stream has been opened, and there wasn't an error. If
>+    // using an HTTP proxy, bootstrap using the CONNECT method.
>+    if (this.proxy && this.proxy.type == "http") {
>+      this.LOG("Bootstrapping http proxy.");
>+      this.sendData("CONNECT " + this.host + ":" + this.port +
>+                    " HTTP/1.1\r\n\r\n");
>+      this.disconnect();
>+      return;
These two lines were for testing. :) They shouldn't be here.

Comment 6

[Chris Nighswonger]

Is any movement on this foreseen?

We have Thunderbird Chat users behind a corporate proxy who cannot use the chat due to https traffic being proxied.

Comment 7

[Patrick Cloke [:clokep]]

Chris, the main issue here is that I have no way of testing this! Do you have a suggestion of a proxy configuration I can use to test this? I had played with some before and was never positive I was seeing the  same behavior as users. Thanks!

Comment 8

[Chris Nighswonger]

I can do testing, but will need a build for x64 Windows 10. I normally work on *nix platforms and therefore am not set up to build on Windows.

Comment 9

[Chris Nighswonger]

Patrick,

Just noticed that this was JS...

So here is what I have going:

Thunderbird 45.6.0

1. We run Squid3 behind a content filter (e2guardian). Both simply pass SSL through.
2. Under 'Tools>Options>How TB Connects to the Internet' the proxy is configured for our network.
3. When connecting to Google Talk via the chat client, the user is prompted for credentials by the proxy.
4. However, the client never completes the connection, eventually timing out.
5. Tcpdump shows the chat clients attempting to connect directly to the remote host on 443 rather than to the proxy.
6. This fails due to port 443 being blocked at the FW for all hosts except the proxy.

https traffic from other applications proxies without issue, so it seems that the chat client is not properly respecting the proxy settings in Thunderbird.

I am able and willing to do any testing which might help resolve the issue.

Comment 10

[Patrick Cloke [:clokep]]

Thanks for the steps you're using to test this! I'll need to see if I can get a proxy installed with similar settings to play with. I'll try to look into this soon. :)