955109 - Enable "minimize on startup"

Status: RESOLVED WONTFIX

(Instantbird Graveyard :: Contacts window, enhancement)

Description

[Instantbot]

*** Original post on bio 1680 by Giuseppe De Luca <it.delucag AT gmail.com> at 2012-08-27 21:08:00 UTC ***

I am trying to minimize Instantbird on startup, but there is no option.

I tried the -silent command line, but it won't even start.

Would be cool if it was implemented in the preferences menu :)

Comment 1

[aleth [:aleth]]

*** Original post on bio 1680 at 2012-08-27 21:12:04 UTC ***

At least the -silent option should be repaired, as we list it on "instantbird --help".

Currently on Linux, -silent stops the contact window from opening, but it also stops the tray icon from appearing, and so effectively breaks IB.

It is handled at http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/nsDefaultCLH.js#78

Comment 3

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1680 as attmnt 2221 at 2013-02-04 21:53:00 UTC ***

For an app that many people will be running in the background all the time, this is a reasonable feature. As it turns out, the --silent command line option really isn't intended for this. I went for adding a hidden pref which can be set to true either by an add-on or directly by the user.

The implementation is a bit hackisch as window.open does not support opening windows in a minimized state, and it turns out the window load event is fired before the OS has actually finished creating the window, so we have to wait for it to be focused (the buddy list is always focused on startup).

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8353984 [details] [diff] [review]
Patch

*** Original change on bio 1680 attmnt 2221 at 2013-02-07 13:15:04 UTC ***

I agree with Florian's comment over IRC...if this is touching "internal" mintrayr preferences, it should probably be part of the mintrayr code.

Additionally, maybe name the pref extensions.mintrayr.startMinimized? (Or "minimizeonstart" or something.)

Comment 5

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1680 as attmnt 2223 at 2013-02-07 13:29:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[aleth [:aleth]]

Comment on attachment 8353984 [details] [diff] [review]
Patch

*** Original change on bio 1680 attmnt 2221 at 2013-02-07 13:29:39 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 7

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1680 as attmnt 2224 at 2013-02-07 13:41:00 UTC ***

Move pref into the section which is #ifdef'd out on OSX.

Comment 8

[aleth [:aleth]]

Comment on attachment 8353986 [details] [diff] [review]
Patch

*** Original change on bio 1680 attmnt 2223 at 2013-02-07 13:41:20 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 9

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1680 as attmnt 2225 at 2013-02-08 10:41:00 UTC ***

Move code to use this._prefs local variable.

Comment 10

[aleth [:aleth]]

Comment on attachment 8353987 [details] [diff] [review]
Patch

*** Original change on bio 1680 attmnt 2224 at 2013-02-08 10:41:57 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 11

[Instantbot]

*** Original post on bio 1680 by Jose Filipe <filipesbim AT yahoo.com.br> at 2013-02-08 11:28:13 UTC ***

In my case, the options instantbird --silent does not work ! :-(
It runs well, but do not show instantbird icon in systray ... !

Mintrayr is deprecated in current state ... but if the works continue, and covers not only windows, but kde, gnome, xfce ... may be a good addon ;-)

Regards

Comment 12

[Patrick Cloke [:clokep]]

Comment on attachment 8353988 [details] [diff] [review]
Patch

*** Original change on bio 1680 attmnt 2225 at 2013-02-09 14:01:04 UTC ***

I haven't tested this, but the code looks fine to me.

Comment 13

[Patrick Cloke [:clokep]]

*** Original post on bio 1680 at 2013-02-09 14:03:40 UTC ***

(In reply to comment #8)
> In my case, the options instantbird --silent does not work ! :-(
> It runs well, but do not show instantbird icon in systray ... !
As was stated above, this is NOT what the silent command is for.

> Mintrayr is deprecated in current state ... 
Mintrayr is included in I stantbird. This comment has no bearing on our implementation.

Comment 14

[Benedikt Pfeifer]

*** Original post on bio 1680 at 2013-02-17 12:39:21 UTC ***

http://hg.instantbird.org/instantbird/rev/2ed0a195817b

Comment 15

[aleth [:aleth]]

*** Original post on bio 1680 at 2013-02-17 14:06:26 UTC ***

Could someone verify this works on Windows please? Thanks!

Comment 16

[Patrick Cloke [:clokep]]

*** Original post on bio 1680 at 2013-02-17 14:40:54 UTC ***

(In reply to comment #12)
> Could someone verify this works on Windows please? Thanks!

It works when minimizing, but not minimizing to tray, as far as I can tell.

Comment 17

[aleth [:aleth]]

*** Original post on bio 1680 at 2013-02-20 14:05:05 UTC ***

(In reply to comment #13)
> It works when minimizing, but not minimizing to tray, as far as I can tell.
I'm a bit surprised a window on Windows can receive focus while not being fully created. 

Could someone please test switching the event from "focus" to "activate"? (This event also works on Linux)
http://lxr.instantbird.org/instantbird/source/instantbird/components/mintrayr/content/mintrayr.js#58

Comment 18

[Instantbot]

*** Original post on bio 1680 by Jose Filipe <filipesbim AT yahoo.com.br> at 2013-02-21 10:57:42 UTC ***

Sorry Aleph ! 

But to test this i have to install mintrayr, right ?
And how do i apply your patch ??

Regards

Comment 19

[aleth [:aleth]]

*** Original post on bio 1680 at 2013-02-21 11:00:41 UTC ***

(In reply to comment #15)
>But to test this i have to install mintrayr, right ?
To test the current patch all you need to do is to use the current nightly build (http://ftp.instantbird.com/instantbird/nightly/latest-trunk/) and set the preference extensions.mintrayr.startMinimized to true.

Comment 20

[Instantbot]

*** Original post on bio 1680 by Jose Filipe <filipesbim AT yahoo.com.br> at 2013-02-21 11:22:21 UTC ***

Congratulations, great job ! loool
This is finaly working, i tested somme times and its starts minimized :-)
Finaly its done :-)

This is a feature that had falts in instantbird, i think that the next priority is develop feature to lock buddys that had spam / virus ... !

Until its done, i had to disable account icq, because a icq buddy / contact emits spam / virus ... !

Regards

Comment 21

[aleth [:aleth]]

*** Original post on bio 1680 at 2013-02-21 12:27:56 UTC ***

(In reply to comment #17)
> Congratulations, great job ! loool
> This is finaly working, i tested somme times and its starts minimized :-)
> Finaly its done :-)
Glad it works for you!

> This is a feature that had falts in instantbird, i think that the next priority
> is develop feature to lock buddys that had spam / virus ... ! 
> Until its done, i had to disable account icq, because a icq buddy / contact
> emits spam / virus ... !
This is the wrong place to discuss buddy blocking - it's off-topic to this bug. We're aware it's a wanted feature. You may wish to cc yourself to bug 953582 (bio 135).

Comment 22

[Patrick Cloke [:clokep]]

*** Original post on bio 1680 at 2013-03-09 16:46:12 UTC ***

(In reply to comment #14)
> (In reply to comment #13)
> > It works when minimizing, but not minimizing to tray, as far as I can tell.
> I'm a bit surprised a window on Windows can receive focus while not being fully
> created. 
> 
> Could someone please test switching the event from "focus" to "activate"? (This
> event also works on Linux)
> http://lxr.instantbird.org/instantbird/source/instantbird/components/mintrayr/content/mintrayr.js#58

This did not work. :(

Comment 23

[aleth [:aleth]]

This bug is still open for Windows.

Comment 24

[Sylvestre Ledru [:Sylvestre]]

On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.

Comment 25

[Sylvestre Ledru [:Sylvestre]]

On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.

Comment 26

[Sylvestre Ledru [:Sylvestre]]

On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.