Tooltip for conversations don't show whois information (if conversation target isn't buddy)

RESOLVED FIXED in Instantbird 48

Status

Chat Core
General
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: clokep, Assigned: nhnt11)

Tracking

(Depends on: 2 bugs, Blocks: 1 bug)

trunk
Instantbird 48
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
*** Original post on bio 1691 at 2012-09-07 16:27:00 UTC ***

ALl IRC conversations should be capable of showing the WHOIS information in the tooltip, currently this is only possible if the target is on your buddy list.

Comment 1

4 years ago
*** Original post on bio 1691 at 2012-09-07 16:48:25 UTC ***

This sounds like it should really be fixed as part of fixing bug 954049 (bio 613) - though of course it would be much easier to fix just this bug.
(Reporter)

Comment 2

4 years ago
*** Original post on bio 1691 at 2013-03-25 15:49:49 UTC ***

(In reply to comment #1)
> This sounds like it should really be fixed as part of fixing bug 954049 (bio 613) - though
> of course it would be much easier to fix just this bug.

This requires us to just add an ircAccountBuddy for each conversation, bug 954049 (bio 613) requires a bit more logic to call track/untrackBuddy.
Blocks: 954049, 955200

Updated

3 years ago
No longer blocks: 954049
Depends on: 954049
(Assignee)

Comment 3

2 years ago
Created attachment 8733158 [details] [diff] [review]
Patch

This was a simple patch, I think we should land this considering bug 954049 is still a WIP.
Attachment #8733158 - Flags: review?(aleth)

Comment 4

2 years ago
Comment on attachment 8733158 [details] [diff] [review]
Patch

Review of attachment 8733158 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/content/imtooltip.xml
@@ +338,5 @@
>           }
>           else {
>             this.setAttribute("status", "unknown");
>             this.setMessage(Status.toLabel("unknown"));
> +           this.requestBuddyInfo(account, account.getNormalizedChatBuddyName(aConv.name));

getNormalizedChatBuddyName isn't a method of accounts, but of MUCs.
Attachment #8733158 - Flags: review?(aleth) → review-
(Assignee)

Comment 5

2 years ago
Created attachment 8733649 [details] [diff] [review]
Patch v2

Changed it to use aConv.normalizedName, and added a comment about the hackiness as discussed on IRC.
Assignee: nobody → nhnt11
Attachment #8733158 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8733649 - Flags: review?(aleth)

Updated

2 years ago
Attachment #8733649 - Flags: review?(aleth) → review+

Updated

2 years ago
Component: IRC → General
Keywords: checkin-needed

Updated

2 years ago
Summary: Tooltip for IRC conversations don't show whois information (if conversation target isn't buddy) → Tooltip for conversations don't show whois information (if conversation target isn't buddy)

Comment 6

2 years ago
https://hg.mozilla.org/comm-central/rev/c01c2a11089ff7824b3d0ce7db48c4735fb1cd97
Bug 955119 - Request buddy info when updating tooltip from a conv without a linked buddy. r=aleth

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 48

Updated

2 years ago
Depends on: 1270988
You need to log in before you can comment on or make changes to this bug.