955119 - Tooltip for conversations don't show whois information (if conversation target isn't buddy)

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 1691 at 2012-09-07 16:27:00 UTC ***

ALl IRC conversations should be capable of showing the WHOIS information in the tooltip, currently this is only possible if the target is on your buddy list.

Comment 1

[aleth [:aleth]]

*** Original post on bio 1691 at 2012-09-07 16:48:25 UTC ***

This sounds like it should really be fixed as part of fixing bug 954049 (bio 613) - though of course it would be much easier to fix just this bug.

Comment 2

[Patrick Cloke [:clokep]]

*** Original post on bio 1691 at 2013-03-25 15:49:49 UTC ***

(In reply to comment #1)
> This sounds like it should really be fixed as part of fixing bug 954049 (bio 613) - though
> of course it would be much easier to fix just this bug.

This requires us to just add an ircAccountBuddy for each conversation, bug 954049 (bio 613) requires a bit more logic to call track/untrackBuddy.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

This was a simple patch, I think we should land this considering bug 954049 is still a WIP.

Comment 4

[aleth [:aleth]]

Comment on attachment 8733158 [details] [diff] [review]
Patch

Review of attachment 8733158 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/content/imtooltip.xml
@@ +338,5 @@
>           }
>           else {
>             this.setAttribute("status", "unknown");
>             this.setMessage(Status.toLabel("unknown"));
> +           this.requestBuddyInfo(account, account.getNormalizedChatBuddyName(aConv.name));

getNormalizedChatBuddyName isn't a method of accounts, but of MUCs.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch v2

Changed it to use aConv.normalizedName, and added a comment about the hackiness as discussed on IRC.

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/c01c2a11089ff7824b3d0ce7db48c4735fb1cd97
Bug 955119 - Request buddy info when updating tooltip from a conv without a linked buddy. r=aleth