Closed Bug 955119 Opened 6 years ago Closed 4 years ago

Tooltip for conversations don't show whois information (if conversation target isn't buddy)

Categories

(Chat Core :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 48

People

(Reporter: clokep, Assigned: nhnt11)

References

(Depends on 2 open bugs, Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1691 at 2012-09-07 16:27:00 UTC ***

ALl IRC conversations should be capable of showing the WHOIS information in the tooltip, currently this is only possible if the target is on your buddy list.
*** Original post on bio 1691 at 2012-09-07 16:48:25 UTC ***

This sounds like it should really be fixed as part of fixing bug 954049 (bio 613) - though of course it would be much easier to fix just this bug.
*** Original post on bio 1691 at 2013-03-25 15:49:49 UTC ***

(In reply to comment #1)
> This sounds like it should really be fixed as part of fixing bug 954049 (bio 613) - though
> of course it would be much easier to fix just this bug.

This requires us to just add an ircAccountBuddy for each conversation, bug 954049 (bio 613) requires a bit more logic to call track/untrackBuddy.
Blocks: 954049, 955200
No longer blocks: 954049
Depends on: 954049
Attached patch Patch (obsolete) — Splinter Review
This was a simple patch, I think we should land this considering bug 954049 is still a WIP.
Attachment #8733158 - Flags: review?(aleth)
Comment on attachment 8733158 [details] [diff] [review]
Patch

Review of attachment 8733158 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/content/imtooltip.xml
@@ +338,5 @@
>           }
>           else {
>             this.setAttribute("status", "unknown");
>             this.setMessage(Status.toLabel("unknown"));
> +           this.requestBuddyInfo(account, account.getNormalizedChatBuddyName(aConv.name));

getNormalizedChatBuddyName isn't a method of accounts, but of MUCs.
Attachment #8733158 - Flags: review?(aleth) → review-
Attached patch Patch v2Splinter Review
Changed it to use aConv.normalizedName, and added a comment about the hackiness as discussed on IRC.
Assignee: nobody → nhnt11
Attachment #8733158 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8733649 - Flags: review?(aleth)
Attachment #8733649 - Flags: review?(aleth) → review+
Component: IRC → General
Keywords: checkin-needed
Summary: Tooltip for IRC conversations don't show whois information (if conversation target isn't buddy) → Tooltip for conversations don't show whois information (if conversation target isn't buddy)
https://hg.mozilla.org/comm-central/rev/c01c2a11089ff7824b3d0ce7db48c4735fb1cd97
Bug 955119 - Request buddy info when updating tooltip from a conv without a linked buddy. r=aleth
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 48
Depends on: 1270988
You need to log in before you can comment on or make changes to this bug.