955128 - Contact selection is messed up with selecting the contact below the selected contact on an unfocused contact list

Status: RESOLVED FIXED

(Instantbird Graveyard :: Contacts window, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 1700 at 2012-09-17 15:50:00 UTC ***

11:45:09 AM - clokep_work: Know who you have currently have highlighted on the contact list (the contact is the double sized one.)
11:45:19 AM - clokep_work: Focus off the list (and the large contact goes away).
11:45:29 AM - clokep_work: Now click on the contact BELOW the one that was highlighted.
11:45:40 AM - clokep_work: And the contact that was highlighted becomes big again and is selected.
11:47:06 AM - florian: clokep_work: I'm not very surprised
11:47:23 AM - florian: the contact stays selected, so it's re-expanded when the list is focused
11:47:41 AM - florian: it's just that the focus event is handled before the click event, which kinda makes sense
11:47:49 AM - florian: (even though the result is obviously a bug :))

Comment 3

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1700 as attmnt 2403 at 2013-04-22 14:15:00 UTC ***

This clears the buddy list selection when the contact window loses focus. (This bug does not occur when the listbox has lost focus, but the window still has focus.)

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8354170 [details] [diff] [review]
Patch

*** Original change on bio 1700 attmnt 2403 at 2013-04-27 14:10:31 UTC ***

This looks fine to me. I'm going to attach a new patch which applies properly with the ifdef in this file.

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Patch ready for check-in

*** Original post on bio 1700 as attmnt 2415 at 2013-04-27 14:12:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[Patrick Cloke [:clokep]]

*** Original post on bio 1700 at 2013-04-28 03:15:54 UTC ***

http://hg.instantbird.org/instantbird/rev/8d63f09a6b2b

Thanks!