955167 - Handle XMPP room join failure 403: Forbidden

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[Instantbot]

*** Original post on bio 1736 by spiffytech AT gmail.com at 2012-10-22 20:18:00 UTC ***

I tried to join an XMPP chatroom I didn't have access to, and Instantbird appeared to do nothing. I checked the error log and saw the below error. Trying to join the same room from Pidgin showed me the XMPP error message ("403: Forbidden", I think it was), so I assume libpurple is passing Instantbird something it could display to the user as a clue to why nothing happened.

--
Error: Notification: Error joining chat <chat> (Error joining chat <chat>)

Source File: http://hg.instantbird.org/instantbird/raw-file/4df52d793c89/purple/libpurple/notify.c 

Line 99

notify: purple_notify_message

----

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 1736 at 2013-03-26 13:18:01 UTC ***

Confirming.

Comment 2

[aleth [:aleth]]

This was filed for libpurple, converting it for JS-XMPP.

Comment 3

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 1 - Handle XMPP room join forbidden

Comment 4

[aleth [:aleth]]

Comment on attachment 8615595 [details] [diff] [review]
rev 1 - Handle XMPP room join forbidden

Thanks, that was quick! Shows the surrounding code was well structured.

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/fa5ffb98e7b4