Handle XMPP room join failure 403: Forbidden

RESOLVED FIXED in 1.6

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: bugzilla, Assigned: abdelrahman)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
*** Original post on bio 1736 by spiffytech AT gmail.com at 2012-10-22 20:18:00 UTC ***

I tried to join an XMPP chatroom I didn't have access to, and Instantbird appeared to do nothing. I checked the error log and saw the below error. Trying to join the same room from Pidgin showed me the XMPP error message ("403: Forbidden", I think it was), so I assume libpurple is passing Instantbird something it could display to the user as a clue to why nothing happened.

--
Error: Notification: Error joining chat <chat> (Error joining chat <chat>)

Source File: http://hg.instantbird.org/instantbird/raw-file/4df52d793c89/purple/libpurple/notify.c 

Line 99

notify: purple_notify_message

----
*** Original post on bio 1736 at 2013-03-26 13:18:01 UTC ***

Confirming.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

4 years ago
This was filed for libpurple, converting it for JS-XMPP.
Blocks: 954959
Severity: enhancement → normal
Component: Other → XMPP
Depends on: 1087357
Product: Instantbird → Chat Core
Summary: Display XMPP errors to the user when you can't join a chatroom → Handle XMPP room join failure 403: Forbidden
(Assignee)

Comment 3

4 years ago
Assignee: nobody → a.ahmed1026
Status: NEW → ASSIGNED
Attachment #8615595 - Flags: review?(aleth)

Comment 4

4 years ago
Comment on attachment 8615595 [details] [diff] [review]
rev 1 - Handle XMPP room join forbidden

Thanks, that was quick! Shows the surrounding code was well structured.
Attachment #8615595 - Flags: review?(aleth) → review+

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.