955199 - Can't auth with ZNC server

Status: VERIFIED FIXED

(Chat Core :: IRC, defect)

Description

[Instantbot]

*** Original post on bio 1767 by spiffytech AT gmail.com at 2012-11-05 17:56:00 UTC ***

A nightly that came out sometime since Thursday or Friday refuses to auth with my ZNC IRC bouncer anymore. I get this message when trying to connect:

----
*** You need to send your password. Try /quote PASS <username>:<password>
----
(following those directions just has Instantbird complaining that I'm disconnected)


I also see these new messages in the Instantbird error console, which may or may not be related, see bug 955185 (bio 1753):

----
Timestamp: 11/5/12 12:47:22 PM
Warning: Unhandled IRC message: :hitchcock.freenode.net CAP * LS :account-notify extended-join identify-msg multi-prefix sasl
Source File: jar:file:///Applications/Instantbird%20Nightly.app/Contents/MacOS/omni.ja!/components/irc.js
Line: 617
Source Code:
irc
----

----
Timestamp: 11/5/12 12:51:15 PM
Error: Received unexpected ERROR response:
Closing link [Timeout]
Source File: resource:///modules/ircBase.jsm
Line: 166
Source Code:
irc
----

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 1767 at 2012-11-05 19:42:55 UTC ***

We no longer send the PASS command automatically, the solution to this (in my mind) is to add an advanced option to support a "Server password" which is used by the PASS command.

Comment 2

[Patrick Cloke [:clokep]]

*** Original post on bio 1767 at 2012-11-08 17:10:26 UTC ***

So I see 4 ways forward with this:
1. Add a (hidden) option for each account to send the PASS command.
2. Add a hidden option for each account which is the server password, if this property exists, we send PASS.
3. Add a global option to use "legacy auth" for IRC.
4. Add a "masked" (i.e. like a password) option to each account for a "server password". If this is set we would send it as PASS. This needs to be handled in the UI, IRC protocol and chat backend (to use the password manager for a "masked" option).

4 is the best choice, in my opinion, but almost definitely cannot make it into 1.3.

I do not like 3 because you might only want to use PASS on a single server / bouncer.

1 & 2 are both reasonable to me, but I'm concerned how easy they would be to migrate to 4. They would force some reconfiguration of the affect accounts, however.

I'm leaning toward implementing 2 right now.

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Patch

*** Original post on bio 1767 as attmnt 2072 at 2012-11-08 17:32:00 UTC ***

This implements #2, you can add a server password by creating a new string preference: messenger.accounts.account<#>.options.serverPassword and setting this to the password needed to log into the server.

For the case of a bouncer, you would also remove the account's password, most likely, as I think ZNC caches your actual credentials to authenticate to the server with.

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8353832 [details] [diff] [review]
Patch

*** Original change on bio 1767 attmnt 2072 at 2012-11-08 18:06:58 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Patrick Cloke [:clokep]]

*** Original post on bio 1767 at 2012-11-09 00:44:12 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/8c055fcede9f

Comment 6

[Instantbot]

*** Original post on bio 1767 by spiffytech AT gmail.com at 2012-11-09 14:08:39 UTC ***

I confirm that this is fixed in the latest nightly, though for future reference for anyone seeing this ticket, the config string is messenger.account.account<#>.options.serverPassword (note the singular 'account'). Account numbers start counting from 1, in the order they appear in Tools -> Accounts.

Comment 7

[Florian Quèze [:florian]]

*** Original post on bio 1767 at 2012-11-09 15:31:53 UTC ***

(In reply to comment #5)

> Account numbers start counting from 1, in the order they appear in
> Tools -> Accounts.

You can reorder the accounts in the account manager, and that doesn't change the number.

Comment 8

[Florian Quèze [:florian]]

*** Original post on bio 1767 at 2012-11-09 15:32:38 UTC ***

(In reply to comment #5)
> I confirm that this is fixed in the latest nightly

Thanks!