Closed Bug 955688 Opened 10 years ago Closed 10 years ago

Existing conversations should filter on all contacts

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file, 4 obsolete files)

*** Original post on bio 2240 at 2013-11-06 16:53:00 UTC ***

Bug 955486 (bio 2049) is not fixed yet for existing conversations.
Blocks: 955013, 955486
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2240 as attmnt 3022 at 2013-11-09 15:01:00 UTC ***

Smells like duplication, but that'll go away if existing conversations are implemented differently.
Attachment #8354803 - Flags: review?(nhnt11)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2240 as attmnt 3023 at 2013-11-09 15:02:00 UTC ***

Not sure how that happened.
Attachment #8354804 - Flags: review?(nhnt11)
Comment on attachment 8354803 [details] [diff] [review]
Patch

*** Original change on bio 2240 attmnt 3022 at 2013-11-09 15:02:47 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354803 - Attachment is obsolete: true
Attachment #8354803 - Flags: review?(nhnt11)
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2240 as attmnt 3024 at 2013-11-09 15:04:00 UTC ***

Now I know. Sorry.
Attachment #8354805 - Flags: review?(nhnt11)
Comment on attachment 8354804 [details] [diff] [review]
Patch

*** Original change on bio 2240 attmnt 3023 at 2013-11-09 15:04:09 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354804 - Attachment is obsolete: true
Attachment #8354804 - Flags: review?(nhnt11)
Comment on attachment 8354805 [details] [diff] [review]
Patch

*** Original change on bio 2240 attmnt 3024 at 2013-11-25 16:57:17 UTC ***

Maybe clokep can steal this review.
Attachment #8354805 - Flags: review?(clokep)
*** Original post on bio 2240 at 2013-11-25 17:27:35 UTC ***

Comment on attachment 8354805 [details] [diff] [review] (bio-attmnt 3024)
Patch

>+      let names = aUIConv.contact.getBuddies().map(b => b.displayName);
>+      this._lowerCaseName = names.join(" ").toLowerCase();

You don't need the "names" variable here.
Attached patch Patch2 (obsolete) — Splinter Review
*** Original post on bio 2240 as attmnt 3081 at 2013-11-25 17:34:00 UTC ***

> You don't need the "names" variable here.

Of course not, it was just one of two possible ways to get around the character limit...
Attachment #8354862 - Flags: review?(florian)
Comment on attachment 8354805 [details] [diff] [review]
Patch

*** Original change on bio 2240 attmnt 3024 at 2013-11-25 17:34:43 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354805 - Attachment is obsolete: true
Attachment #8354805 - Flags: review?(nhnt11)
Attachment #8354805 - Flags: review?(clokep)
Attached patch Patch3Splinter Review
*** Original post on bio 2240 as attmnt 3082 at 2013-11-25 18:31:00 UTC ***

This time, inserted in the right if clause.
Attachment #8354863 - Flags: review?(florian)
Comment on attachment 8354862 [details] [diff] [review]
Patch2

*** Original change on bio 2240 attmnt 3081 at 2013-11-25 18:31:13 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354862 - Attachment is obsolete: true
Attachment #8354862 - Flags: review?(florian)
Comment on attachment 8354863 [details] [diff] [review]
Patch3

*** Original change on bio 2240 attmnt 3082 at 2013-11-25 18:36:44 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354863 - Flags: review?(florian) → review+
*** Original post on bio 2240 at 2013-11-25 18:43:59 UTC ***

http://hg.instantbird.org/instantbird/rev/aece6e24d63a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.