955738 - Port 'Bug 733632 - Remove TLS version UI (Options > Advanced > Encryption > Protocols)'

Status: RESOLVED FIXED

(Instantbird Graveyard :: Preferences, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 2286 at 2013-12-15 12:48:00 UTC ***

This UI was changed in Mozilla 23. We should port it, but it's not a pure string removal (there's one string changed/added) so we can't do it for 1.5. It's also not a completely broken UI, so it's OK to do it at the next cycle.

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Patch v1

I did this by copying the relevant files from browser and then stripping out various components we don't use.

I tested this by clicking around and ensuring the prefs updated properly.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8638492 [details] [diff] [review]
Patch v1

Review of attachment 8638492 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure the "Data Choices" tab makes sense for Instantbird.

::: im/content/preferences/connection.js
@@ +105,5 @@
>      var proxyTypeCur = document.getElementById("network.proxy.type").value;
>  
> +    var prefs =
> +        Components.classes["@mozilla.org/preferences-service;1"].
> +        getService(Components.interfaces.nsIPrefBranch);

This change doesn't seem desirable.

::: im/locales/en-US/chrome/instantbird/preferences/advanced.dtd
@@ +7,5 @@
>  <!ENTITY generalTab.label                "General">
>  
>  <!ENTITY accessibility.label             "Accessibility">
>  
> +<!ENTITY useCursorNavigation.label       "Always use the cursor keys to navigate within pages">

Please revert this to the Instantbird wording talking about conversations.

@@ +12,4 @@
>  <!ENTITY useCursorNavigation.accesskey   "c">
>  <!ENTITY searchStartTyping.label         "Search for text when I start typing">
>  <!ENTITY searchStartTyping.accesskey     "x">
> +<!ENTITY blockAutoRefresh.label          "Warn me when websites try to redirect or reload the page">

Doesn't seem relevant to Instantbird.

@@ +17,2 @@
>  
> +<!ENTITY browsing.label                  "Browsing">

This change doesn't seem intentional.

@@ +36,5 @@
>  <!ENTITY configEdit.accesskey            "E">
>  
> +<!ENTITY dataChoicesTab.label            "Data Choices">
> +
> +<!ENTITY crashReporterDesc.label         "&brandShortName; submits crash reports to help &vendorShortName; make your browser more stable and secure">

This string isn't appropriate for Instantbird.

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Patch v2

I ended up removing the data choices tab, so that took care of a few comments.

I did not change to using Services.prefs in connection.js since we had modified this file to add imServices at the top. It seems better to keep it in sync with browser.

I made the request string changes and reverted some XUL around the conversation options group.

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/0b348fa4d344

Comment 6

[Patrick Cloke [:clokep]]

Updating milestone from 1.6 to 42.