955989 - Running additional-extensions.js and download-manager.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #955988 +++

Comment 1

[Ricky Chien [:rickychien] (inactive)]

additional-extensions.js requires download-manager.js as download handler but download-manager could be replace entirely by alternative node modules. As a result, we're not going to convert download-manager.js anymore and it will be required when we're running on xpcshell in additional-extensions.js.

Mark bug 1131504 as dup since above reason.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:bug-955989 > mozilla-b2g:master

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8721247 [details] [review]
[gaia] rickychien:bug-955989 > mozilla-b2g:master

Yo, I didn't expect such large changes to refactor for additional-extensions.js.

Lots of works are modifying utils's zip API in order to support compatibility for xpc and node.

Please take a look! thank you.

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8721247 [details] [review]
[gaia] rickychien:bug-955989 > mozilla-b2g:master

Looks good. Tested with flag DESKTOP=1. Thanks for the patch.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/ed8a35177153bc8a0af3ab8fd1a8118ff4b12636