Closed
Bug 9560
Opened 26 years ago
Closed 25 years ago
DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98)
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M16
People
(Reporter: jimmykenlee, Assigned: dbragg)
References
Details
(Keywords: platform-parity)
Build: 7/9/99 SeaMonkey build
1. Use http://jimbob/trigger2.html
2. Trigger http://jimbob/jars/a_diskspaceavailable.jar
Note: Using drop-down button from trigger page crashes on Linux
3. Excerpt from installscript:
f = Install.GetFolder("Communicator");
space = Install.DiskSpaceAvailable(f);
Install.LogComment("DiskSpaceAvailable:\t" + space);
RESULT:
From Macintosh:
Installscript completes gracefully. Install.log shows:
---------------------------------------------------------------------------
Acceptance: a_diskspaceavailable
---------------------------------------------------------------------------
Starting Installation at 07/09/1999 15:08:51
Comment: DiskSpaceAvailable: 513386496
Finished Installation 07/09/1999 15:08:51
From Linux:
Installscript completes gracefully. Install.log shows:
---------------------------------------------------------------------------
Acceptance: a_diskspaceavailable
---------------------------------------------------------------------------
Starting Installation at 07/09/1999 15:08:51
Finished Installation 07/09/1999 15:08:51
EXPECTED RESULT:
For Macintosh, the disk space available shows 489.7 MB or the correct reading.
For Linux, the disk space available should show.
Updated•26 years ago
|
Assignee: dveditz → dougt
Comment 1•26 years ago
|
||
Giving this one to Doug due to Mac involvement (sorry!).
Updated•26 years ago
|
Assignee: dougt → ssu
Severity: major → normal
Target Milestone: M11
Summary: [PP]DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux) → DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98)
Build 7/27/99
You can now add Windows 98 to the list of platforms that is having a problem.
The same jar file returned -946962432 as the disk space available. This number
should have been 1200128000.
Windows NT behaves as expected.
Summary: DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98) → [feature] DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98)
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
fixed. It was converting a PRUint32 type to a PRInt32 type. That's where the
negative number came in.
Besides that, it shouldn't be using a 32bit type integer because hard disk
drives can be bigger than 4gig. It should try to use a 64bit type. I'll file
that as a seperate bug.
Build 9/10/99
I get the same response from all platforms. The Install.log shows:
---------------------------------------------------------------------------
http://jimbob/jars/a_diskspaceavailable.jar -- 09/13/1999 14:36:05
---------------------------------------------------------------------------
Acceptance: a_diskspaceavailable
** DiskSpaceAvailable: undefined
Install completed successfully
Finished Installation 09/13/1999 14:36:06
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → WORKSFORME
Comment 7•25 years ago
|
||
works for me.
---------------------------------------------------------------------------
http://jimbob/jars/a_diskspaceavailable.jar -- 09/20/1999 14:40:27
---------------------------------------------------------------------------
Acceptance: a_diskspaceavailable
** DiskSpaceAvailable: 2545049600
Install completed successfully
Finished Installation 09/20/1999 14:41:52
Build 9/20/99
I'm getting a slight discrepancy from what XPInstall tells me compared to the
OS. WinNT is fine. For example:
Win98
-----
XPInstall ** DiskSpaceAvailable: 854097920
OS 854130688
Mac 8.5
-------
XPInstall ** DiskSpaceAvailable: 240726528
OS 229.6 MB
Linux
-----
XPInstall ** DiskSpaceAvailable: 1425374208
OS 5930584
Updated•25 years ago
|
Status: REOPENED → ASSIGNED
Comment 10•25 years ago
|
||
Mac 8.5
-------
( 240726528 / 1024 ) / 1024 == 229.57470703125
Win98
-----
XPInstall ** DiskSpaceAvailable: 854097920
OS 854130688
- ---------
-32768
off by 32k.
The above are fine. round off error when convering print64 to double accounts.
Linux
-----
XPInstall ** DiskSpaceAvailable: 1425374208
OS 5930584
odd. how are you calculating the diskspace?
Reporter | ||
Comment 11•25 years ago
|
||
Thanks, Doug. For Linux, I used the "df" utility to view available disk space.
I also doubted what I found. Samir helped me verify what I found.
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Comment 12•25 years ago
|
||
use 'df -g'. on the machine jimmylee I used the version of df in /usr/bin.
What you want to do with this output is:
(Total number of free blocks - 1)(block size)
This should produce a number which is the upper bound of the disk space avail.
Reporter | ||
Comment 13•25 years ago
|
||
There still is a calculation problem with Linux. I talked to Doug, and he
agrees there is a problem.
One consideration I have is whether this needs to be resolved by Beta 1. It
works for Mac and Windows.
Comment 14•25 years ago
|
||
Clearing FIXED resolution due to reopen.
Summary: [feature] DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98) → [PP][feature] DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98)
Target Milestone: M11 → M14
Comment 15•25 years ago
|
||
move to M14 (monday 10/4 meeting)
Comment 16•25 years ago
|
||
Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine
Comment 17•25 years ago
|
||
will be fixed by 22047
Comment 18•25 years ago
|
||
see 24984
Comment 20•25 years ago
|
||
moving to m15
Updated•25 years ago
|
Summary: [PP][feature] DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98) → [feature] DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98)
Comment 21•25 years ago
|
||
reassign to dbragg
bug meeting 3/20
Assignee: dougt → dbragg
Status: REOPENED → NEW
Comment 23•25 years ago
|
||
The value you now get back is exactly what is reported by nsILocalFile. Marking
as fixed.
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 24•25 years ago
|
||
Builds: 2000-05-03-08-M16(LINUX), 2000-05-08-09-M16(WIN), 2000-05-08-08-M16(MAC)
Done.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 25•25 years ago
|
||
Build: 2000-05-10-09-M16(WIN), 2000-05-10-08-M16(MAC), 2000-05-10-09-M16(LINUX)
I screwed up. The test to check is a_diskspaceavailable.xpi. Currently, the
install.log returns -229. With Doug's new change, the install.log also reports
that diskSpaceAvailable is not defined Line:17.
Are we going to support this from the Install object or are we going to go with
just File.diskSpaceAvailable, or do we really want to support both?
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 26•25 years ago
|
||
We plan to support those functions under File object only. We will need to
disable those functions under Install object, if they're not already done.
Reporter | ||
Comment 27•25 years ago
|
||
If we are going to only support this from the File object, then I suggest that
we disable the Install object support and put this old bug behind us.
Essentially, we don't want this form to work anyway.
Comment 28•25 years ago
|
||
Removing feature designation. We are not supporting
Install.DiskSpaceAvailable() or Install.diskSpaceAvailable() so the script
calling it is correctly returning -229 because it doesn't know about that
function. Only the File. version is supported.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Summary: [feature] DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98) → DiskSpaceAvailable: Returned free disk space value differs from actual (Mac, Linux, Win98)
Reporter | ||
Comment 29•25 years ago
|
||
Confirmed that we are no longer supporting Install.DiskSpaceAvailable() or
Install.diskSpaceAvailable(). Marking Verified!
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•