Closed Bug 956076 Opened 11 years ago Closed 10 years ago

[Rocketbar] Is shown when a user dismisses the utility tray

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review 
Currently the Rocketbar displays if the user focuses within the left ~65% of the statusbar. Unfortunately we do this both when the utility tray is shown, and not shown. This results in the rocketbar being shown when we dismiss the utility tray occasionally.
Attached file Github pull request — 
Looking for a review from either of you :) It's only a one-liner, but I added a bunch of rocketbar tests to utility_tray_test.js. Thanks!
Attachment #8355256 - Flags: review?(alive)
Attachment #8355256 - Flags: review?(21)
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Comment on attachment 8355256 [details] [review]
Github pull request

This one seems simple enough, so going to land. Alive - let me know if you have any follow-ups and I will address them.
Attachment #8355256 - Flags: review?(alive)
Landed: https://github.com/mozilla-b2g/gaia/commit/9a84edf8dcfe9eb640c5aaa2109c01096bfb8dd6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: