[keyboard refactor] convert layout files to new format

RESOLVED FIXED in 1.4 S5 (11apr)

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: djf, Assigned: rudyl)

Tracking

unspecified
1.4 S5 (11apr)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [keyboard2-feature-parity])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
The refactored keyboard in test_apps/demo-keyboard/ uses a new simplified layout file format that will be much easier for localizers and others to customize.

But we have many existing layouts in the old format that need to be converted.

This bug is for writing a script to convert the old format to the new format.
(Reporter)

Updated

5 years ago
Blocks: 956169
Assignee: nobody → rlu
Target Milestone: --- → 1.4 S5 (11apr)
Depends on: 994539
Created attachment 8404623 [details] [review]
Pull request 18151

WIP patch to add the layout definitions in new format.

--
My script to do the covert lives in,
https://github.com/RudyLu/gaia/tree/keyboard/Bug956182-convert_layout_format_script
Whiteboard: [keyboard2-feature-parity]
Comment on attachment 8404623 [details] [review]
Pull request 18151

Patch updated to add the layouts in new format.

Tim,

Please help review this.
Thanks.
Attachment #8404623 - Flags: review?(timdream)
Status: NEW → ASSIGNED
Comment on attachment 8404623 [details] [review]
Pull request 18151

Thanks. Please upload your conversion script as attachment here for record keeping.
Attachment #8404623 - Flags: review?(timdream) → review+
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/7b82adf8845eab68703d10d9064fc4401667f34f

Thanks.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Created attachment 8408167 [details]
script to convert the format

I patched keyboard-config.js directly so that it could do the work.
just do |APP=keyboard make| and it will generate the new layouts under build_stage.
You need to log in before you can comment on or make changes to this bug.