Closed
Bug 994539
Opened 10 years ago
Closed 10 years ago
[keyboard refactor] layout definition could borrow key def from predefined pages
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S5 (11apr)
People
(Reporter: rudyl, Assigned: rudyl)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #956182 +++ The refactored keyboard in test_apps/demo-keyboard/ uses a new simplified layout file format that will be much easier for localizers and others to customize. When you define NUMBERS or other page of layouts, you should be able to borrow the key definition from the predefined pages, e.g. "ALT" key in NUMBERS page. This will make customizing a NUMBERS page easier without specifying all the predefined keys.
Assignee | ||
Comment 1•10 years ago
|
||
Tim, Please help review this small change. I send this first because bug 956182 would need this fix. Thanks.
Attachment #8404514 -
Flags: review?(timdream)
Updated•10 years ago
|
Attachment #8404514 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Landed to Gaia master, https://github.com/RudyLu/gaia/commit/bd5b188258cd4cc8207439fc2131c3807520c834 -- Tim, thanks for the review.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 1.4 S5 (11apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•