956193 - [Flatfish]Graphics rendering is slow when hardware composer enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Tzu-Lin Huang [:dwi2][:tzhuang]]

This only happens on flatfish.
Recently, flatfish build enable hardware composer by default.

Steps:

1. Settings -> Device Information -> More Information -> Developer
2. Uncheck 'Enable hardware composer'

Actual result: 
  graphics rendering becomes smooth

Expect result
  graphics rendering should also be smooth even when 'Enable hardware composer' is checked.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Checkbox 'Enable hardware composer' maps to 'layers.composer2d.enabled'

Comment 2

[[e-mail]]

@thomas, 

in Flatfish disable the 'Enable hardware composer' option in developer settings make Graphics rendering smooth.

Is there any side effect that we disable it?

Comment 3

[[e-mail]]

I mean only disable this option in Flatfish default preference, not affect the overall settings on phone.

Comment 4

[thomas tsai]

hwcomposer is not fully tested in flatfish, so it can be manually disabled.

Comment 5

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Proposed patch to disable 'layers.composer2d.enabled' as workaround since it is really painful to debug or test on flatfish now.

Hi Tim,

Would you like to review the patch? thanks

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Thanks,

landed on master https://github.com/mozilla-b2g/gaia/commit/2e8b91c6f02e47deb3888ba5bd3906887d30dbb3

Comment 7

[Sotaro Ikeda [:sotaro]]

Disabling hw composer could generally degrade the power consumption especially during video playback and Web Page rendering. This configuration is not suit for production in general.

Comment 8

[Asa Dotzler [:asa]]

Is there a bug on file to re-enable when it's fixed or to fix the problem that caused the disabling?

Comment 9

[[e-mail]]

Since it's our first reference tablet for development, its worth to make the reference tablet just work.

The distribution_tablet is a reference customization set, any partner that wants to go production should fork from it and have their customization set.


Francis, as Asa comment in Comment 8, could you help followup the hardware composer issue?

Comment 10

[Francis Lee [:frlee]]

hi All,

we have another bug: https://bugzilla.mozilla.org/show_bug.cgi?id=956265 tracks this issue. the root cause was found in commen4 (bug 956256)