Closed Bug 956202 Opened 10 years ago Closed 10 years ago

Intermittent TEST-UNEXPECTED-FAIL | browser_UITour.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 29
Tracking Flags:
Tracking Status
firefox27 --- unaffected
firefox28 --- unaffected
firefox29 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: KWierso, Assigned: Gijs)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files, 1 obsolete file)

split off UITour checking functions,
4.43 KB, patch
Unfocused
: review+
Gijs
: checkin+
Details | Diff | Splinter Review
split off some of the UITour tests,
16.78 KB, patch
Unfocused
: review+
Gijs
: checkin+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=32490453&tree=Mozilla-Inbound
slave: talos-r4-snow-127



14:27:10     INFO -  ++DOCSHELL 0x1733bc0b0 == 46 [pid = 913] [id = 6798]
14:27:10     INFO -  ++DOMWINDOW == 374 (0x14fdbfa58) [pid = 913] [serial = 17199] [outer = 0x0]
14:27:10     INFO -  ++DOMWINDOW == 375 (0x149b672d8) [pid = 913] [serial = 17200] [outer = 0x14fdbfa58]
14:27:10     INFO -  [Parent 913] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 265
14:27:10     INFO -  [Parent 913] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 265
14:27:10     INFO -  ++DOMWINDOW == 376 (0x154f910d8) [pid = 913] [serial = 17201] [outer = 0x14fdbfa58]
14:27:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Menu should initially be closed
14:27:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Menu should be shown after showMenu()
14:27:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Menu should be closed after hideMenu()
14:27:11     INFO -  [Parent 913] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 265
14:27:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility
14:27:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be closed/hidden after UITour tab is closed
14:27:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility
14:27:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Tooltip should be closed/hidden after UITour tab is closed
14:27:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | @noautohide on the menu panel should have been cleaned up
14:27:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Any pinned tab should be closed after UITour tab is closed
14:27:14     INFO -  --DOCSHELL 0x171117c60 == 45 [pid = 913] [id = 6787]
14:27:14     INFO -  --DOCSHELL 0x16ce120c0 == 44 [pid = 913] [id = 6786]
14:27:14     INFO -  --DOCSHELL 0x1726a8ba0 == 43 [pid = 913] [id = 6785]
14:27:14     INFO -  --DOCSHELL 0x16ee30f10 == 42 [pid = 913] [id = 6784]
14:27:14     INFO -  --DOCSHELL 0x171f93f20 == 41 [pid = 913] [id = 6772]
14:27:14     INFO -  --DOCSHELL 0x1728d80a0 == 40 [pid = 913] [id = 6771]
14:27:14     INFO -  --DOCSHELL 0x171980bd0 == 39 [pid = 913] [id = 6770]
14:27:14     INFO -  --DOCSHELL 0x1757eaaf0 == 38 [pid = 913] [id = 6782]
14:27:14     INFO -  --DOCSHELL 0x16e800cd0 == 37 [pid = 913] [id = 6781]
14:27:14     INFO -  --DOCSHELL 0x1734b3780 == 36 [pid = 913] [id = 6780]
14:27:14     INFO -  --DOCSHELL 0x170d7ef00 == 35 [pid = 913] [id = 6779]
14:27:14     INFO -  --DOCSHELL 0x175a60850 == 34 [pid = 913] [id = 6778]
14:27:14     INFO -  --DOCSHELL 0x16e6c49c0 == 33 [pid = 913] [id = 6777]
14:27:14     INFO -  --DOCSHELL 0x1747918e0 == 32 [pid = 913] [id = 6776]
14:27:14     INFO -  --DOCSHELL 0x1715ceb00 == 31 [pid = 913] [id = 6775]
14:27:14     INFO -  --DOCSHELL 0x1711309f0 == 30 [pid = 913] [id = 6774]
14:27:14     INFO -  --DOCSHELL 0x17285d640 == 29 [pid = 913] [id = 6773]
14:27:14     INFO -  --DOCSHELL 0x16e7395c0 == 28 [pid = 913] [id = 6769]
14:27:14  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.
14:27:14     INFO -  TEST-INFO | MEMORY STAT vsize after test: 4418306048
14:27:14     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 957030400
14:27:14     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | finished in 32805ms
Blair, please may you take a look at this? (Started ~3rd Jan)
Assignee: nobody → bmcbride
Blocks: fx-UITour
Flags: needinfo?(bmcbride)
Huh. We must have been right at the threshold on OSX and Linux, as the only thing that we landed before that was on the 10th December.
Status: NEW → ASSIGNED
Flags: needinfo?(bmcbride)
also backedout bug 935815 again, since after landing this bug occured again
So let's start off by making splitting up easier...
Attachment #8358002 - Flags: review?(bmcbride)
Assignee: bmcbride → gijskruitbosch+bugs
Comment on attachment 8358002 [details] [diff] [review]
split off UITour checking functions,

Review of attachment 8358002 [details] [diff] [review]:
-----------------------------------------------------------------

<3
Attachment #8358002 - Flags: review?(bmcbride) → review+
... and then split them up.
Attachment #8358007 - Flags: review?(bmcbride)
Slightly too fast, this time with the requisite manifest addition. And, I checked this locally, and it runs the tests and passes here.
Attachment #8358010 - Flags: review?(bmcbride)
Attachment #8358007 - Attachment is obsolete: true
Attachment #8358007 - Flags: review?(bmcbride)
Comment on attachment 8358010 [details] [diff] [review]
split off some of the UITour tests,

Review of attachment 8358010 [details] [diff] [review]:
-----------------------------------------------------------------

<3
Attachment #8358010 - Flags: review?(bmcbride) → review+
Attachment #8358002 - Flags: checkin+
Attachment #8358010 - Flags: checkin+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Depends on: 967370
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: