B2G RIL: no need to deactivate data call before radio off

RESOLVED WONTFIX

Status

Firefox OS
RIL
RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: aknow, Assigned: aknow)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
We don't have to do it. Remove the code.
(Assignee)

Comment 1

5 years ago
Created attachment 8355467 [details] [diff] [review]
Part 1: No need to deactivate data call before radio off
Attachment #8355467 - Flags: review?(htsai)
(Assignee)

Comment 2

5 years ago
Created attachment 8355468 [details] [diff] [review]
Part 2: Modify test
Attachment #8355468 - Flags: review?(htsai)
(In reply to Szu-Yu Chen [:aknow] from comment #0)
> We don't have to do it. Remove the code.

Why? We had them merged in bug 908603.  So what's the effect after reverting them here?
Depends on: 908603
Flags: needinfo?(szchen)
Flags: needinfo?(jjong)
(In reply to Vicamo Yang [:vicamo][:vyang] (PTO Dec. 21 ~ Jan. 5) from comment #3)
> (In reply to Szu-Yu Chen [:aknow] from comment #0)
> > We don't have to do it. Remove the code.
> 
> Why? We had them merged in bug 908603.  So what's the effect after reverting
> them here?

In Bug 909688 we have handled data connectivity lost cases properly, so there should be no problem in gecko side if we remove 'powerOffRadioSafely()' now, but I think we still need modem's confirmation if they are okay with this. Please see Bug 856553 comment 98.
Flags: needinfo?(jjong)
(Assignee)

Comment 5

5 years ago
Bug 883065, looks like modem had already resolved the problem, so we don't have to deactivate the data call by ourself. In addition, I will also check the patch on unagi and fugu device to make sure there is no problem on modem.
Flags: needinfo?(szchen)
(Assignee)

Comment 6

5 years ago
(In reply to Szu-Yu Chen [:aknow] from comment #5)
> Bug 883065, looks like modem had already resolved the problem, so we don't
> have to deactivate the data call by ourself. In addition, I will also check
> the patch on unagi and fugu device to make sure there is no problem on modem.

Verified on unagi and fugu.
Data connection works well after turn off and then turn on the radio.
(In reply to Szu-Yu Chen [:aknow] from comment #6)
> (In reply to Szu-Yu Chen [:aknow] from comment #5)
> > Bug 883065, looks like modem had already resolved the problem, so we don't
> > have to deactivate the data call by ourself. In addition, I will also check
> > the patch on unagi and fugu device to make sure there is no problem on modem.
> 
> Verified on unagi and fugu.
> Data connection works well after turn off and then turn on the radio.

I also tested with buri, and it worked as expected.
Comment on attachment 8355467 [details] [diff] [review]
Part 1: No need to deactivate data call before radio off

Review of attachment 8355467 [details] [diff] [review]:
-----------------------------------------------------------------

Don't forget that we'd need to remove "Cu.import("resource://gre/modules/Promise.jsm");"
Attachment #8355467 - Flags: review?(htsai)

Updated

5 years ago
Attachment #8355468 - Flags: review?(htsai) → review+
(Assignee)

Comment 9

5 years ago
Created attachment 8357005 [details] [diff] [review]
Part 1#2: No need to deactivate data call before radio off

address comment
Attachment #8357005 - Flags: review?(htsai)
(Assignee)

Updated

5 years ago
Attachment #8355467 - Attachment is obsolete: true
Comment on attachment 8357005 [details] [diff] [review]
Part 1#2: No need to deactivate data call before radio off

Review of attachment 8357005 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thank you for the work.
Attachment #8357005 - Flags: review?(htsai) → review+
(In reply to Szu-Yu Chen [:aknow] from comment #6)
> (In reply to Szu-Yu Chen [:aknow] from comment #5)
> > Bug 883065, looks like modem had already resolved the problem, so we don't
> > have to deactivate the data call by ourself. In addition, I will also check
> > the patch on unagi and fugu device to make sure there is no problem on modem.
> 
> Verified on unagi and fugu.
> Data connection works well after turn off and then turn on the radio.

Did you test fugu and fugu-DSDS both? If no, please help make sure they both are covered. And in fugu-DSDS, we'd carefully check the cases that data call is on sim1 and on sim2. Thank you!
(Assignee)

Comment 12

5 years ago
Created attachment 8357532 [details] [diff] [review]
[final] Part 1: No need to deactivate data call before radio off. r=hsinyi
Attachment #8357005 - Attachment is obsolete: true
Attachment #8357532 - Flags: review+
(Assignee)

Comment 13

5 years ago
Created attachment 8357534 [details] [diff] [review]
[final] Part 2: Modify test. r=hsinyi
Attachment #8355468 - Attachment is obsolete: true
Attachment #8357534 - Flags: review+

Updated

5 years ago
Keywords: checkin-needed
Finally got reply with the perspective of modem: confirmation

"The reason for PowerOffSafely is not related to local behavior, rather it's about being nice to the network.
Locally the modem will clean up everything on power off and, as you noticed, we are told that the data call is down via DATA_CALL_LIST_CHANGED message.
However on the network side the network isn't notified that the device is going down and doesn't get the chance to clean up resources associated with that data call (at least until some timeout happen on their side, assuming they are some contingency in place to cleanup stale connections). Explicitly deactivating the data call on power down is the device being a good citizen and allows the network to free up the resources more readily."

Though we don't see re-connection problem with this patch, to make our FFOS a good citizen to the network world, let's keep what we have now. Close as WONTFIX. Sorry for that, and thanks again!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.