[Search] Suggestions results are cleared unexpectedly

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Suggestion results are being cleared. I think this is happening because we call .clear() for all messages (not just suggestion requests).
(Assignee)

Updated

4 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 8355637 [details] [review]
Pull Request, Follow-up (Testing)

Also going to take this opportunity to add tests.
(Assignee)

Comment 2

4 years ago
Comment on attachment 8355637 [details] [review]
Pull Request, Follow-up (Testing)

Hi Dale, Amir - This is essentially a very small patch, but I did add a lot of unit tests because I wanted this app to be well tested. If one of you could take a quick look - maybe skim over the tests it would be appreciated. Thanks!
Attachment #8355637 - Flags: review?(dale)
Attachment #8355637 - Flags: review?(amirn)

Comment 3

4 years ago
Comment on attachment 8355637 [details] [review]
Pull Request, Follow-up (Testing)

r+ for the 'clearing results' bugfix, but I am not comfortable reviewing the tests since I'm not familiar with sinon.js

I guess green Travis means the everything is OK, but I would prefer we split the tests to a new bug.

Thanks.
Attachment #8355637 - Flags: review?(amirn) → review+
(Assignee)

Comment 4

4 years ago
Comment on attachment 8355637 [details] [review]
Pull Request, Follow-up (Testing)

I think you taking a look is good enough for me, but I will probably split up the commits to be safe. Thanks!
Attachment #8355637 - Flags: review?(dale)
(Assignee)

Comment 5

4 years ago
Created attachment 8355893 [details] [review]
Github pull request
(Assignee)

Updated

4 years ago
Attachment #8355637 - Attachment description: Github pull request → Pull Request, Follow-up (Testing)
(Assignee)

Comment 7

4 years ago
Landed tests: https://github.com/mozilla-b2g/gaia/commit/00c1426b61237bbdfa9f76eb33decaad9d2110ae
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.