Closed Bug 956393 Opened 6 years ago Closed 6 years ago
[Search] Suggestions results are cleared unexpectedly
Suggestion results are being cleared. I think this is happening because we call .clear() for all messages (not just suggestion requests).
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Also going to take this opportunity to add tests.
Comment on attachment 8355637 [details] [review] Pull Request, Follow-up (Testing) Hi Dale, Amir - This is essentially a very small patch, but I did add a lot of unit tests because I wanted this app to be well tested. If one of you could take a quick look - maybe skim over the tests it would be appreciated. Thanks!
Comment on attachment 8355637 [details] [review] Pull Request, Follow-up (Testing) r+ for the 'clearing results' bugfix, but I am not comfortable reviewing the tests since I'm not familiar with sinon.js I guess green Travis means the everything is OK, but I would prefer we split the tests to a new bug. Thanks.
Attachment #8355637 - Flags: review?(amirn) → review+
Comment on attachment 8355637 [details] [review] Pull Request, Follow-up (Testing) I think you taking a look is good enough for me, but I will probably split up the commits to be safe. Thanks!
Attachment #8355637 - Attachment description: Github pull request → Pull Request, Follow-up (Testing)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.