Closed
Bug 956655
Opened 10 years ago
Closed 10 years ago
WebMobileConnection: move mobileConnection DOM classes out of namesapce mozilla::dom::network to mozilla::dom
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(2 files, 6 obsolete files)
9.74 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
12.63 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
It seems we don't need to put MobileConnection into an extra namespacing, 'mozilla::dom::network', maybe we can just stick these in 'mozilla::dom'. And in this bug, I would like to move mobileConnection related *.idl/*.js/*.c/*.h into '$GECKO_ROOT/dom/mobileconnection' given that there are many files will be created for the IPDL implementation in bug 843452, having a extra folder for mobileConnection makes the file hierarchies more clear. (Please see bug 843452 comment #6)
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8356039 [details] [diff] [review] Part 1: Move MobileConnection related files to dom/mobileconnection, v1 Hi smaug, need your help to review this, thank you.
Attachment #8356039 -
Flags: review?(bugs)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8356041 [details] [diff] [review] Part 2: Move MobileConnection DOM classes to namespacing mozilla::dom, v1 Hi smaug, need your help to review this, thank you.
Attachment #8356041 -
Flags: review?(bugs)
Updated•10 years ago
|
Attachment #8356041 -
Flags: review?(bugs) → review+
Comment 5•10 years ago
|
||
Comment on attachment 8356039 [details] [diff] [review] Part 1: Move MobileConnection related files to dom/mobileconnection, v1 Could you explain why we need to create the new directory for just few files? mobileconnection doesn't sound too different to network, so I don't quite see the reason. In general we don't try to put every small feature into its own directory. (I think I asked this in some other bug, but perhaps I missed the answer)
Attachment #8356039 -
Flags: review?(bugs)
Flags: needinfo?(echen)
Assignee | ||
Comment 6•10 years ago
|
||
Hi smaug, Sorry for doesn't make thinks clear first. For the reason that I would like to create the new directory is mentioned in bug 843452 comment #6. If you think it is not necessary to do this, I will keep them in original folder. :) Thank you. (In reply to Olli Pettay [:smaug] from comment #5) > Comment on attachment 8356039 [details] [diff] [review] > Part 1: Move MobileConnection related files to dom/mobileconnection, v1 > > Could you explain why we need to create the new directory for just few files? > mobileconnection doesn't sound too different to network, so I don't quite > see the reason. In general we don't try to put every small feature into > its own directory. > > (I think I asked this in some other bug, but perhaps I missed the answer)
Flags: needinfo?(echen) → needinfo?(bugs)
Comment 7•10 years ago
|
||
Comment on attachment 8356039 [details] [diff] [review] Part 1: Move MobileConnection related files to dom/mobileconnection, v1 Ok, I had missed the comment in the other bug. Technically this needs a build peer review too.
Attachment #8356039 -
Flags: review+
Flags: needinfo?(bugs)
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8356039 [details] [diff] [review] Part 1: Move MobileConnection related files to dom/mobileconnection, v1 (In reply to Olli Pettay [:smaug] from comment #7) > Comment on attachment 8356039 [details] [diff] [review] > Part 1: Move MobileConnection related files to dom/mobileconnection, v1 > > Technically this needs a build peer review too. Hi Kyle, In this patch, I would like to move mobileConnection related *.idl/*.js/*.c/*.h into '$GECKO_ROOT/dom/mobileconnection' given that there are many files will be created for the IPDL implementation (Please see bug 843452 comment #6 for more details). Could you help to review this? Thank you :)
Attachment #8356039 -
Flags: review?(khuey)
Attachment #8356039 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Add r=khuey after r+.
Attachment #8356039 -
Attachment is obsolete: true
Attachment #8356953 -
Flags: review+
Assignee | ||
Comment 10•10 years ago
|
||
Full try: https://tbpl.mozilla.org/?tree=Try&rev=a3b764ab6d27
Assignee | ||
Comment 11•10 years ago
|
||
I would like to wait bug 952043 landing first.
Assignee | ||
Comment 12•10 years ago
|
||
Rebase only.
Attachment #8356953 -
Attachment is obsolete: true
Attachment #8360872 -
Flags: review+
Assignee | ||
Comment 13•10 years ago
|
||
Rebase only.
Attachment #8356041 -
Attachment is obsolete: true
Attachment #8360873 -
Flags: review+
Assignee | ||
Comment 14•10 years ago
|
||
Full try: https://tbpl.mozilla.org/?tree=Try&rev=04175f1527aa
Assignee | ||
Comment 15•10 years ago
|
||
Rebase only.
Attachment #8360873 -
Attachment is obsolete: true
Attachment #8361469 -
Flags: review+
Assignee | ||
Comment 16•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/10348da2438a https://hg.mozilla.org/integration/b2g-inbound/rev/eb886e5b4250
Assignee | ||
Comment 17•10 years ago
|
||
Backed out because I found there is a miss for new test file, test_mobile_connections_array_uninitialized.js, which was added in bug 953005. I should double check before push, sorry about this. :( https://hg.mozilla.org/integration/b2g-inbound/rev/3391d092f6df https://hg.mozilla.org/integration/b2g-inbound/rev/0e5d3ec9d4c0
Assignee | ||
Comment 18•10 years ago
|
||
Rebase for bug 953005 (comment #17).
Attachment #8360872 -
Attachment is obsolete: true
Attachment #8361494 -
Flags: review+
Assignee | ||
Comment 19•10 years ago
|
||
Rebase for bug 939038.
Attachment #8361494 -
Attachment is obsolete: true
Attachment #8361553 -
Flags: review+
Assignee | ||
Comment 20•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/25b073c67d69 https://hg.mozilla.org/integration/b2g-inbound/rev/15fc92fc7c1e
Comment 21•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/25b073c67d69 https://hg.mozilla.org/mozilla-central/rev/15fc92fc7c1e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•