956655 - WebMobileConnection: move mobileConnection DOM classes out of namesapce mozilla::dom::network to mozilla::dom

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Edgar Chen [:edgar] (PTO until 02/09)]

It seems we don't need to put MobileConnection into an extra namespacing, 'mozilla::dom::network', maybe we can just stick these in 'mozilla::dom'.

And in this bug, I would like to move mobileConnection related *.idl/*.js/*.c/*.h into '$GECKO_ROOT/dom/mobileconnection' given that there are many files will be created for the IPDL implementation in bug 843452, having a extra folder for mobileConnection makes the file hierarchies more clear. (Please see bug 843452 comment #6)

Comment 1

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Part 1: Move MobileConnection related files to dom/mobileconnection, v1

Comment 2

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Part 2: Move MobileConnection DOM classes to namespacing mozilla::dom, v1

Comment 3

[Edgar Chen [:edgar] (PTO until 02/09)]

Comment on attachment 8356039 [details] [diff] [review]
Part 1: Move MobileConnection related files to dom/mobileconnection, v1

Hi smaug, need your help to review this, thank you.

Comment 4

[Edgar Chen [:edgar] (PTO until 02/09)]

Comment on attachment 8356041 [details] [diff] [review]
Part 2: Move MobileConnection DOM classes to namespacing mozilla::dom, v1

Hi smaug, need your help to review this, thank you.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8356039 [details] [diff] [review]
Part 1: Move MobileConnection related files to dom/mobileconnection, v1

Could you explain why we need to create the new directory for just few files?
mobileconnection doesn't sound too different to network, so I don't quite
 see the reason. In general we don't try to put every small feature into
its own directory.

(I think I asked this in some other bug, but perhaps I missed the answer)

Comment 6

[Edgar Chen [:edgar] (PTO until 02/09)]

Hi smaug,

Sorry for doesn't make thinks clear first.
For the reason that I would like to create the new directory is mentioned in bug 843452 comment #6.
If you think it is not necessary to do this, I will keep them in original folder. :)

Thank you.

(In reply to Olli Pettay [:smaug] from comment #5)
> Comment on attachment 8356039 [details] [diff] [review]
> Part 1: Move MobileConnection related files to dom/mobileconnection, v1
> 
> Could you explain why we need to create the new directory for just few files?
> mobileconnection doesn't sound too different to network, so I don't quite
>  see the reason. In general we don't try to put every small feature into
> its own directory.
> 
> (I think I asked this in some other bug, but perhaps I missed the answer)

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8356039 [details] [diff] [review]
Part 1: Move MobileConnection related files to dom/mobileconnection, v1

Ok, I had missed the comment in the other bug.

Technically this needs a build peer review too.

Comment 8

[Edgar Chen [:edgar] (PTO until 02/09)]

Comment on attachment 8356039 [details] [diff] [review]
Part 1: Move MobileConnection related files to dom/mobileconnection, v1

(In reply to Olli Pettay [:smaug] from comment #7)
> Comment on attachment 8356039 [details] [diff] [review]
> Part 1: Move MobileConnection related files to dom/mobileconnection, v1
>
> Technically this needs a build peer review too.

Hi Kyle,

In this patch, I would like to move mobileConnection related *.idl/*.js/*.c/*.h into '$GECKO_ROOT/dom/mobileconnection' given that there are many files will be created for the IPDL implementation (Please see bug 843452 comment #6 for more details). Could you help to review this?

Thank you :)

Comment 9

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Part 1: Move MobileConnection related files to dom/mobileconnection, v1, r=smaug,khuey

Add r=khuey after r+.

Comment 10

[Edgar Chen [:edgar] (PTO until 02/09)]

Full try: https://tbpl.mozilla.org/?tree=Try&rev=a3b764ab6d27

Comment 11

[Edgar Chen [:edgar] (PTO until 02/09)]

I would like to wait bug 952043 landing first.

Comment 12

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Part 1: Move MobileConnection related files to dom/mobileconnection, v2, r=smaug,khuey

Rebase only.

Comment 13

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Part 2: Move MobileConnection DOM classes to namespacing mozilla::dom, v2, r=smaug

Rebase only.

Comment 14

[Edgar Chen [:edgar] (PTO until 02/09)]

Full try: https://tbpl.mozilla.org/?tree=Try&rev=04175f1527aa

Comment 15

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Part 2: Move MobileConnection DOM classes to namespacing mozilla::dom, v3, r=smaug

Rebase only.

Comment 16

[Edgar Chen [:edgar] (PTO until 02/09)]

https://hg.mozilla.org/integration/b2g-inbound/rev/10348da2438a
https://hg.mozilla.org/integration/b2g-inbound/rev/eb886e5b4250

Comment 17

[Edgar Chen [:edgar] (PTO until 02/09)]

Backed out because I found there is a miss for new test file, test_mobile_connections_array_uninitialized.js, which was added in bug 953005.
I should double check before push, sorry about this. :(

https://hg.mozilla.org/integration/b2g-inbound/rev/3391d092f6df
https://hg.mozilla.org/integration/b2g-inbound/rev/0e5d3ec9d4c0

Comment 18

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Part 1: Move MobileConnection related files to dom/mobileconnection, v3, r=smaug,khuey

Rebase for bug 953005 (comment #17).

Comment 19

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Part 1: Move MobileConnection related files to dom/mobileconnection, v4, r=smaug,khuey

Rebase for bug 939038.

Comment 20

[Edgar Chen [:edgar] (PTO until 02/09)]

https://hg.mozilla.org/integration/b2g-inbound/rev/25b073c67d69
https://hg.mozilla.org/integration/b2g-inbound/rev/15fc92fc7c1e

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25b073c67d69
https://hg.mozilla.org/mozilla-central/rev/15fc92fc7c1e