Closed Bug 961647 Opened 7 years ago Closed 7 years ago

Follow-up of bug 956655: Remove dom/network/src/MobileConnection* which should be deleted in bug 956655

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #956655 +++

dom/network/src/MobileConnection* should be deleted after bug 956655.
But it seems I did not apply the original patch correctly after backout process.
So these files still there and only be removed in dom/network/src/moz.build.
File this follow-up bug to delete these redundant files.
Attached patch Patch, v1Splinter Review
Comment on attachment 8362454 [details] [diff] [review]
Patch, v1

Hi Kyle, could you help to review this for me? dom/network/src/MobileConnection* should be deleted in bug 956655, but there is something wrong when I push to b2g-inbound after backout (Please see comment #0). Sorry to bother you here :(
Attachment #8362454 - Flags: review?(khuey)
Comment on attachment 8362454 [details] [diff] [review]
Patch, v1

Review of attachment 8362454 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, hg has this fun bug where if you hg import a patch and part of it fails to apply hg will lose all of your hg add/removes in the patch too.  I bet that's what happened here.
Attachment #8362454 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/392fc370a7b0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.