961647 - Follow-up of bug 956655: Remove dom/network/src/MobileConnection* which should be deleted in bug 956655

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a clone of Bug #956655 +++

dom/network/src/MobileConnection* should be deleted after bug 956655.
But it seems I did not apply the original patch correctly after backout process.
So these files still there and only be removed in dom/network/src/moz.build.
File this follow-up bug to delete these redundant files.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8362454 [details] [diff] [review]
Patch, v1

Hi Kyle, could you help to review this for me? dom/network/src/MobileConnection* should be deleted in bug 956655, but there is something wrong when I push to b2g-inbound after backout (Please see comment #0). Sorry to bother you here :(

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8362454 [details] [diff] [review]
Patch, v1

Review of attachment 8362454 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, hg has this fun bug where if you hg import a patch and part of it fails to apply hg will lose all of your hg add/removes in the patch too.  I bet that's what happened here.

Comment 4

[Edgar Chen [:edgar]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=ea51f7bb09db

Comment 5

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/392fc370a7b0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/392fc370a7b0