956666 - [fugu][DSDS]icc.getCardLockRetryCount can't callback.

Status: RESOLVED DUPLICATE of bug 944601

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[sam.hua]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22

Steps to reproduce:

1. open setting->sim manager->sim security->SIM pin
2. open SIM1 PIN


Actual results:

it doesn't show the retry counts


Expected results:

it should show the retry counts

Comment 1

[sam.hua]

i print some logs and find that:
icc.getCardLockRetryCount(lockType, showRetryCount); 

when gecko fire the fire request success, showRetryCount doesn't been called .

Comment 2

[sam.hua]

it block the sanity test.

Comment 3

[Steven Yang [:styang]]

Shawn, could you help to check this issue? Thanks!

Comment 4

[shawn ku [:sku]]

Hi Sam:
 I think the major issue is
"01-07 16:52:34.337  2183  2188 E RILC    : [w] unsupported request code 150 token 107"

Could you please help check if RILD handle message ID : 150 [1] properly. 


// Log snippet
01-07 16:52:34.327  2273  2273 I Gecko   : -*- RadioInterfaceLayer: Received 'RIL:GetCardLockRetryCount' message from content process
01-07 16:52:34.337  2273  2293 I Gecko   : RIL Worker[0]: Received chrome message {"lockType":"pin","requestId":"id{3b3f0f84-4b16-484c-86c1-01a452f54ecc}","rilMessageToken":14,"rilMessageType":"iccGetCardLockRetryCount"}
01-07 16:52:34.337  2273  2293 I Gecko   : RIL Worker[0]: New outgoing parcel of type 150
01-07 16:52:34.337  2183  2188 I RILC    : [w] enter processCommandsCallback
01-07 16:52:34.337  2183  2188 E RILC    : [w] unsupported request code 150 token 107
01-07 16:52:34.337  2273  2293 I Gecko   : RIL Worker[0]: Outgoing parcel: 0,0,0,32,150,0,0,0,107,0,0,0,1,0,0,0,7,0,0,0,83,0,73,0,77,0,32,0,80,0,73,0,78,0,0,0

[1] https://github.com/mozilla/gecko-dev/blob/master/dom/system/gonk/ril_consts.js#L136

Comment 5

[sam.hua]

hi shawn,

our rilc can support the REQUEST_GET_UNLOCK_RETRY_COUNT. do u update it?

my log is :
I/Gecko   (  108): -*- RILContentHelper: Received message 'RIL:CardLockRetryCount': {"clientId":0,"data":{"lockType":"pin","requestId":"id{e600b39e-c038-4697-b1a7-14e582061f9d}","rilMessageToken":7,"rilMessageType":"iccGetCardLockRetryCount","selCode":"SIM PIN","rilRequestType":150,"rilRequestError":0,"success":true,"retryCount":3}}
I/Gecko   (  108): -*- RILContentHelper: fire request success, id: id{e600b39e-c038-4697-b1a7-14e582061f9d}, result: {"lockType":"pin","retryCount":3,"success":true}

Comment 6

[shawn ku [:sku]]

(In reply to sam.hua from comment #5)
> hi shawn,
> 
> our rilc can support the REQUEST_GET_UNLOCK_RETRY_COUNT. do u update it?
> 
> my log is :
> I/Gecko   (  108): -*- RILContentHelper: Received message
> 'RIL:CardLockRetryCount':
> {"clientId":0,"data":{"lockType":"pin","requestId":"id{e600b39e-c038-4697-
> b1a7-14e582061f9d}","rilMessageToken":7,"rilMessageType":
> "iccGetCardLockRetryCount","selCode":"SIM
> PIN","rilRequestType":150,"rilRequestError":0,"success":true,"retryCount":3}}
> I/Gecko   (  108): -*- RILContentHelper: fire request success, id:
> id{e600b39e-c038-4697-b1a7-14e582061f9d}, result:
> {"lockType":"pin","retryCount":3,"success":true}

Sam, thanks for the information.
I am getting the latest code now, will have a trial and give some feedback tomorrow.

Comment 7

[shawn ku [:sku]]

Hi Fernando:
 Could you please help check this issue?
It seems very similiar to Bug 905173.

Thanks!!
sku

Comment 8

[Fernando Campo (:fcampo)]

mmmhh... probably related to https://bugzilla.mozilla.org/show_bug.cgi?id=924949#c7 ??

I thought that we were unable to retrieve a value in advance for the retry count, depending on the ril and modem. Unless there's some new development that I am not aware of.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Edgar found that https://github.com/mozilla-b2g/gaia/blame/master/apps/settings/js/simcard_dialog.js#L397 does not use the API properly. getCardLockRetryCount is a dom request.

Comment 10

[Edgar Chen [:edgar]]

(In reply to Fernando Campo (:fcampo) from comment #8)
> mmmhh... probably related to
> https://bugzilla.mozilla.org/show_bug.cgi?id=924949#c7 ??
> 
> I thought that we were unable to retrieve a value in advance for the retry
> count, depending on the ril and modem. Unless there's some new development
> that I am not aware of.

The rild and modem of Fugu support this feature. Please see bug 946603.
Thank you.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Let's track the issue using the gaia blocker.