Offline error messages are referencing the app://{UUID}, not the app name

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jsmith, Assigned: mikehenrty)

Tracking

({regression})

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:1.3+, b2g-v1.3 verified)

Details

(Whiteboard: [systemsfe][p=3])

Attachments

(2 attachments)

See screenshot. When you render remote web content within a packaged app, the network error connection message is referencing the app://{UUID} in the message, not the app name.
Blocks: 882186
blocking-b2g: --- → 1.3?
Keywords: regression
Whiteboard: [systemsfe]
blocking-b2g: 1.3? → 1.3+
Assignee: nobody → mhenretty
Whiteboard: [systemsfe] → [systemsfe][p=3]
Hi Aus, I realize I will have to rebase this after bug 952305 lands (you were first!), but I figured you could still review this patch in the meantime.
Attachment #8356912 - Flags: review?(aus)
Comment on attachment 8356912 [details] [review]
Fetch App Name for Error Msg

Looks good Mike! Let's land this. :)
Attachment #8356912 - Flags: review?(aus) → review+
Question - Are you making sure that the app name is used in the error message only if we are within an app, not the browser? If you see this error in the browser, then we are still getting the origin in error page, right?
(In reply to Jason Smith [:jsmith] from comment #3)
> Question - Are you making sure that the app name is used in the error
> message only if we are within an app, not the browser? If you see this error
> in the browser, then we are still getting the origin in error page, right?

That's right, in the browser we fallback to using the host.
Comment on attachment 8356912 [details] [review]
Fetch App Name for Error Msg

Rebased against bug 952305. Waiting for travis green before landing.
master: https://github.com/mozilla-b2g/gaia/commit/b58131a2a3a7a9c6e927b02ac87a366d051fa043
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Keywords: verifyme
QA Contact: jsmith
Uplifted b58131a2a3a7a9c6e927b02ac87a366d051fa043 to:
v1.3: 8386c3a8d544b469c87dd1e2973612e55346b6f5
Verified on a 1/26 Buri 1.3 build.
You need to log in before you can comment on or make changes to this bug.