956851 - Offline error messages are referencing the app://{UUID}, not the app name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Jason Smith [:jsmith]]

Attachment: 2014-01-06-12-00-46.png

See screenshot. When you render remote web content within a packaged app, the network error connection message is referencing the app://{UUID} in the message, not the app name.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Fetch App Name for Error Msg

Hi Aus, I realize I will have to rebase this after bug 952305 lands (you were first!), but I figured you could still review this patch in the meantime.

Comment 2

[Aus Lacroix [:aus]]

Comment on attachment 8356912 [details] [review]
Fetch App Name for Error Msg

Looks good Mike! Let's land this. :)

Comment 3

[Jason Smith [:jsmith]]

Question - Are you making sure that the app name is used in the error message only if we are within an app, not the browser? If you see this error in the browser, then we are still getting the origin in error page, right?

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Jason Smith [:jsmith] from comment #3)
> Question - Are you making sure that the app name is used in the error
> message only if we are within an app, not the browser? If you see this error
> in the browser, then we are still getting the origin in error page, right?

That's right, in the browser we fallback to using the host.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8356912 [details] [review]
Fetch App Name for Error Msg

Rebased against bug 952305. Waiting for travis green before landing.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/b58131a2a3a7a9c6e927b02ac87a366d051fa043

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted b58131a2a3a7a9c6e927b02ac87a366d051fa043 to:
v1.3: 8386c3a8d544b469c87dd1e2973612e55346b6f5

Comment 8

[Jason Smith [:jsmith]]

Verified on a 1/26 Buri 1.3 build.